fix broken unit tests by adding required values to vitest mocks & mocking /dynamic/public

Author: dandelany

src/stores/externalResource.test.ts

@@ -2,6 +2,15 @@ import { writable, type Subscriber, type Writable } from 'svelte/store';
 import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
 import type { PlanDataset, Profile, ProfileSegment, Resource } from '../types/simulation';
 
+// required for tests which transitively import `$env/dynamic/public` - unavailable in the vitest environment
+vi.mock('$env/dynamic/public', () => ({
+  env: {
+    PUBLIC_HASURA_CLIENT_URL: 'http://test/hasura',
+    PUBLIC_HASURA_SERVER_URL: 'http://test/hasura',
+    PUBLIC_WORKSPACE_CLIENT_URL: 'http://test/ws',
+  },
+}));
+
 const getExternalProfileSegmentsSinceMock = vi.fn();
 vi.mock('../utilities/effects', () => ({
   default: {
@@ -29,7 +38,15 @@ const planDatasetsMock: PlanDatasetsMock = {
   subscribe: planDatasetsValue.subscribe,
 };
 vi.mock('./plan', () => ({
+  plan: writable({}),
   planDatasets: planDatasetsMock,
+  planEndTimeDoy: writable(''),
+  planId: writable(1),
+  planModelId: writable(1),
+  planModelRevision: writable(1),
+  planRevision: writable(1),
+  planStartTimeMs: writable(''),
+  planStartTimeYmd: writable(''),
 }));
 
 vi.mock('./errors', () => ({

src/stores/profile.test.ts

@@ -2,6 +2,15 @@ import { writable, type Writable } from 'svelte/store';
 import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
 import type { Profile, Resource, SimulationDataset } from '../types/simulation';
 
+// required for tests which transitively import `$env/dynamic/public` - unavailable in the vitest environment
+vi.mock('$env/dynamic/public', () => ({
+  env: {
+    PUBLIC_HASURA_CLIENT_URL: 'http://test/hasura',
+    PUBLIC_HASURA_SERVER_URL: 'http://test/hasura',
+    PUBLIC_WORKSPACE_CLIENT_URL: 'http://test/ws',
+  },
+}));
+
 const getProfileSinceMock = vi.fn();
 vi.mock('../utilities/effects', () => ({
   default: {
@@ -12,6 +21,10 @@ vi.mock('../utilities/effects', () => ({
 const simulationDatasetMock: Writable<SimulationDataset | null> = writable(null);
 vi.mock('./simulation', () => ({
   simulationDataset: simulationDatasetMock,
+  simulationDatasetLatestId: writable(null),
+  simulationDatasetsPlan: writable(null),
+  spanUtilityMaps: writable({}),
+  spansMap: writable({}),
 }));
 
 // Stub: `./errors` transitively pulls `$env/dynamic/public` via requests.ts.

src/stores/profile.ts

@@ -86,7 +86,7 @@ export function createProfileSubscription(
     logMessage(
       'log',
       `Retrieved profile "${name}" (${accumulator.length} segment${pluralize(accumulator.length)}) for dataset ID=${datasetId}.`,
-      {duration: performance.now() - createdAt}
+      { duration: performance.now() - createdAt },
     );
   }
 

src/utilities/effects.ts

@@ -297,13 +297,7 @@ import {
   showWorkspaceBulkOperationConflictModal,
 } from './modal';
 import { featurePermissions, gatewayPermissions, queryPermissions } from './permissions';
-import {
-  reqActionServer,
-  reqExtension,
-  reqGateway,
-  reqHasura,
-  WorkspaceSaveConflictError,
-} from './requests';
+import { reqActionServer, reqExtension, reqGateway, reqHasura, WorkspaceSaveConflictError } from './requests';
 import { convertResponseToMetadata } from './scheduling';
 import { buildSearchActivitiesWhereClauses, type ActivitySearchFilters } from './searchFilters';
 import { compareEvents } from './simulation';

src/utilities/requests.test.ts

@@ -3,6 +3,7 @@ import type { BaseUser } from '../types/app';
 import { ErrorTypes } from './errors';
 import { CompoundError, reqHasura, reqWorkspace, reqWorkspaceWithEtag, WorkspaceSaveConflictError } from './requests';
 
+// required for tests which transitively import `$env/dynamic/public` - unavailable in the vitest environment
 vi.mock('$env/dynamic/public', () => ({
   env: {
     PUBLIC_HASURA_CLIENT_URL: 'http://test/hasura',