Skip to content

Fixes sequence output editor not applying appropriate linting #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dandelany merged 3 commits into from
Apr 22, 2026
Merged

Fixes sequence output editor not applying appropriate linting #1898

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76e092e
fix(sequencing): refresh editor output when extension changes
duranb Mar 24, 2026
0e7fdd4
refactor(sequencing): simplify output editor extension handling and r…
duranb Apr 22, 2026
2b46357
Merge branch 'develop' into fix/sequence-output-linting
dandelany Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/components/sequencing/SequenceEditor.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,14 @@
inputEditorExtension = sequenceAdaptation.input.getEditorExtension(phoenixContext, phoenixResources);
}

$: if (sequenceAdaptation.outputs.length > 0) {
selectedOutputFormat = sequenceAdaptation.outputs[0];
}

$: if (phoenixContext && selectedOutputFormat?.getEditorExtension) {
outputEditorExtension = selectedOutputFormat.getEditorExtension(phoenixContext, phoenixResources);
} else {
outputEditorExtension = [];
}

// insert sequence - use sequenceFilePath as dependency to ensure editor updates when switching files
Expand Down Expand Up @@ -154,10 +160,6 @@
editorHeights = '1fr 3px';
}

$: if (sequenceAdaptation.outputs.length > 0) {
selectedOutputFormat = sequenceAdaptation.outputs[0];
}

$: if (showOutputs && previousShowOutputs !== showOutputs && editorOutputDiv) {
if (editorOutputView) {
editorOutputView.destroy();
Expand Down Expand Up @@ -194,6 +196,15 @@
debouncedOutputUpdate(editorSequenceView?.state.doc.toString() ?? '');
}
}
$: {
// Reconfigure output editor when adaptation extensions change
if (editorOutputView) {
editorOutputView.dispatch({
effects: [compartmentOutputAdaptation.reconfigure(outputEditorExtension)],
});
debouncedOutputUpdate(editorSequenceView?.state.doc.toString() ?? '');
}
}

function sequenceUpdateListener(viewUpdate: ViewUpdate): void {
const sequence = viewUpdate.state.doc.toString();
Expand Down
Loading