Save before navigate in workspace

[AaronPlave]

Summary

Adds a Save and Navigate option to the workspace "unsaved changes" prompt. Previously, leaving a file with unsaved edits meant either discarding them or staying put. Now you can save and continue in one step. Also fixes a couple of related bugs found along the way. Closes #1959

Details

• The unsaved-changes prompt now offers three choices everywhere it appears: switching files, leaving the page, and opening the Actions view: Save and Leave, Discard and Leave, or Keep Editing (Save is the default).
• If a save fails, navigation is cancelled and your edits are kept.
• Saving a brand-new (never-named) file through this prompt opens the save file modal first.
• Fixed a pre-existing bug where switching to the Actions view and back dropped the open file from the URL (broke refresh / deep links).
• The "don't proceed if the save failed" guard now also covers move / rename / download / run-action on a file with unsaved changes.

Visible UX Changes

• New Save and Navigate / Save and Leave button in the unsaved-changes dialog.
• Clearer wording: the dialog is now titled Unsaved Changes, and the discard button reads Discard and Navigate (was "Navigate Away") and is styled as a destructive action so it's obvious it drops your edits.
• Returning to the Files tab keeps the current file in the URL.

Verification

• Added e2e tests to e2e-tests/tests/workspace.test.ts

Manual steps (open a workspace with a couple of sequence files):

1. Save and Navigate — Open file A, make an edit, click file B → Save and Navigate. You land on file B; reopen file A and confirm the edit was saved.
2. Discard and Navigate — Edit file A, click file B → Discard and Navigate. You land on file B; reopen file A and confirm the edit is gone.
3. Keep Editing — Edit file A, click file B → Keep Editing. You stay on file A with the edit intact.
4. Save into the Actions view — Edit a file, click the Actions tab → Save and Navigate, then click back to Files. The file is saved, still open, and present in the URL.
5. Save a brand-new draft — With no file open, type in the editor, click the Actions tab → Save and Navigate → enter a name → Confirm. Back on Files, the new file is open with your content and in the URL (not a blank editor). Refresh to confirm the URL reopens it.
6. Leave the page — Edit a file, then navigate to another section (e.g. Plans). Confirm Save and Leave, Discard and Leave, and Stay on Page each behave as labeled.
7. URL preservation — Open a file, click the Actions tab, then the Files tab. The file is still in the URL; refreshing reopens the same file.
8. Failed save aborts navigation (optional) — In devtools, set the network offline, then choose Save and Navigate. A failure toast appears, navigation is cancelled, and your edits remain.
9. Save before move/rename — Edit a file, then move or rename it and confirm "Save and …". With the network offline, the operation aborts and your edits are kept.

[duranb]

Is it possible to extract the invocation of showUnsavedChangesModal to a function that can be used here and reused in the beforeNavigate?

[AaronPlave]

done

[duranb]

Oh! Sorry. I meant to also include the messages and labels as hardcoded into the function itself so that they wouldn't be repeated in separate places. Is there a desire to make this function flexible?

[AaronPlave]

Ah I see what you mean, there are differences in copy between these invocations so I did a bit more streamlining so that there should be no duplication now. See what you think.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud