Remove WorkspaceService.isMetadataFile in favor of RenderType method

Author: Mythicaeda

workspace-server/src/main/java/gov/nasa/jpl/aerie/workspace/server/WorkspaceFileSystemService.java

@@ -116,14 +116,9 @@ private Path resolveMetadataPath(final Path rootPath, final Path filePath) throw
       throw new WorkspaceFileOpException("Cannot resolve metadata file path: %s is a directory.".formatted(baseFilePath.getFileName()));
     }
 
-    try {
-      if (isMetadataFile(baseFilePath)) {
-        throw new WorkspaceFileOpException("Cannot resolve metadata file path: %s is already a metadata file.".formatted(
-            baseFilePath.getFileName()));
-      }
-    }
-    catch (SQLException se) {
-      throw new WorkspaceFileOpException("Cannot resolve metadata file path: Unable to validate metadata file extensions", se);
+    if (RenderType.isAerieMetadataFile(baseFilePath.getFileName().toString())) {
+      throw new WorkspaceFileOpException("Cannot resolve metadata file path: %s is already a metadata file.".formatted(
+          baseFilePath.getFileName()));
     }
 
     // Convert base file path to metadata file path
@@ -271,11 +266,6 @@ public RenderType getFileType(final Path filePath) throws SQLException {
     return RenderType.getRenderType(fileName, postgresRepository.getExtensionMapping());
   }
 
-  @Override
-  public boolean isMetadataFile(final Path filePath) throws SQLException {
-    return getFileType(filePath) == RenderType.METADATA;
-  }
-
   //region Workspace Operations
   @Override
   public Optional<Integer> createWorkspace(final Path workspaceLocation, final String workspaceName, String username, int parcelId) {

workspace-server/src/main/java/gov/nasa/jpl/aerie/workspace/server/WorkspaceService.java

@@ -112,11 +112,6 @@ boolean copyDirectory(final int sourceWorkspaceId, final Path sourceFilePath, fi
 
   boolean deleteDirectory(final int workspaceId, final Path directoryPath) throws NoSuchWorkspaceException;
 
-  /**
-   * Check if the specified file is a Metadata-type file
-   */
-  boolean isMetadataFile(final Path filePath) throws SQLException;
-
   /**
    * Retrieve the associated metadata file for the given file.
    * Returns an JSON file with only "version" specified in the event said file does not exist.