Skip to content

Allow external sources to have their derivation group changed #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosephVolosin wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow external sources to have their derivation group changed #1779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions deployment/hasura/metadata/databases/tables/merlin/external_source.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ insert_permissions:
check: {}
set:
owner: "x-hasura-user-id"
update_permissions:
- role: aerie_admin
permission:
columns: [derivation_group_name]
filter: {}
- role: user
permission:
columns: [derivation_group_name]
filter: {}
Comment on lines +57 to +60
Copy link
Copy Markdown
Contributor

@Mythicaeda Mythicaeda Feb 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission should have the same filter as in delete, rather than letting any user with the user role change it. (The delete permission says that only the owner of the source OR the owner of the derivation group the source is in can modify the source)

delete_permissions:
- role: aerie_admin
permission:
Expand Down
Loading