Conversation
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
8390b04 to
ec20854
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
ec20854 to
b2a94e4
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
b2a94e4 to
daced4a
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
daced4a to
5ac618e
Compare
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
5ac618e to
99d8a25
Compare
1 task
Mythicaeda
force-pushed
the
feat/workspace-metadata
branch
from
99d8a25 to
b411532
Compare
- Update Move and Copy to consistently use java.nio.Files instead of a mix of java.nio.Files and java.io.File - Update thrown exceptions list for accuracy
- Will no longer include METADATA type files in response - Made RenderType in charge of the Aerie Metadata type for the backend, as that extension is expected to be fairly constant - Remove unneeded Optional wrapper from `listFiles` method
- No longer updates `lastEditedBy` when the metadata is updated (unless that field is missing)
- Move user setup to before tests are run - Move shared User objects to the User helper class - Move APIResponse Body Parser to RequestBodyHelper
…d as readonly - move exceptions into "Exceptions" package
Error Responses were not using the provided Javax serializer on the single item endpoints due to already being converted to JsonObject
Was only running Copy instructions if the user did not have sufficient permissions
- add missing 500 logs to copy/delete
- do not restrict folder rename
dandelany
requested changes
Apr 16, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Reviewed with @Mythicaeda - minor comments added.
Still in progress: reviewing Test files and doing some more backend testing locally
Contributor
Author
|
Comments have been addressed in the 6 newest commits |
dandelany
approved these changes
Apr 21, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
Thanks @Mythicaeda - @AaronPlave and I have reviewed the remaining code and tests & done some more local smoke testing and all looks good. Ready to merge with UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.aerieto.meta.seqdevlistContentsendpoint to hideMETADATA-type files by default, and to provide the contents of the metadata files if thewithMetadataflag is providedVerification
I'd like to add some tests that focus on the contents of the metadata files, and how they're reconstructed after deletion, as well as basic bindings tests for the endpoints.
Documentation
No docs are invalidated, but we should add documenting these new endpoints to writing docs for the other workspace server endpoints
Future work