Small fixes to action server port parsing, github workflows#1827
Merged
Small fixes to action server port parsing, github workflows#1827
Conversation
Mythicaeda
reviewed
May 5, 2026
Mythicaeda
reviewed
May 5, 2026
Mythicaeda
approved these changes
May 5, 2026
Contributor
Mythicaeda
left a comment
Mythicaeda
left a comment
There was a problem hiding this comment.
Approving as neither of my comments are blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweeping up a couple tiny fixes I had in my notes:
parseInt(AERIE_DB_PORT, 5432),like it was a fallback, in fact second argument is radix and this always returns NaN. This caused it to fallback to a default (5432) in another layer and never use customAERIE_DB_PORTif passedinitstep since it uses output from it on line 144. Also updated to make security scan scan the images from the PR branch instead ofdevelop