Fix Cascade Delete Failing when handling Anchored Activities#1839
Open
Mythicaeda wants to merge 2 commits into
Open
Fix Cascade Delete Failing when handling Anchored Activities#1839Mythicaeda wants to merge 2 commits into
Cascade Delete Failing when handling Anchored Activities#1839Mythicaeda wants to merge 2 commits into
Conversation
Mythicaeda
added
fix
…tivities on the same anchor chain in Cascade mode A new function: `deleteIfExists` has been added to `EditablePlan.kt` and `Procedure` has been updated to call it instead. This function will not throw an exception if the activity directive doesn't exist
Mythicaeda
force-pushed
the
fix/scheduler-cascade-auto-delete
branch
from
c0ad761 to
5dc70d6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CascadeDelete When Placed Activities are Anchored to Each Other #1797Description
The
deletePastCreationsmethod has been reworked. It now pre-gathers the set of Activities to delete. Then, ifCASCADEis not the selected deletion strategy, it uses the old behavior of deleting every activity on the list. However, if the deletion strategy isCASCADE, the method now checks that the activity still exists before deleting it (since specifically in theCASCADEcase an activity may have been deleted between being put on the list and the iterator reaching it in the list).Verification
A test going through the reproduction steps on the ticket were added.