Skip to content

Fix intersphinx linking#449

Merged
mkelley merged 1 commit into
NASA-Planetary-Science:mainfrom
mkelley:fix-doc-links-2026.05
May 14, 2026
Merged

Fix intersphinx linking#449
mkelley merged 1 commit into
NASA-Planetary-Science:mainfrom
mkelley:fix-doc-links-2026.05

Conversation

@mkelley

@mkelley mkelley commented May 6, 2026

Copy link
Copy Markdown
Member

from sphinx_astropy.conf.v1 import * was mistakenly deleted in #427 . But while I'm here, add a few more packages for intersphinx linking: numpy, scipy, matplotlib

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@mkelley

mkelley commented May 6, 2026

Copy link
Copy Markdown
Member Author

No change log entry needed.

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.81%. Comparing base (59a8a49) to head (92346cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files          53       53           
  Lines        4267     4267           
=======================================
  Hits         3491     3491           
  Misses        776      776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley mkelley linked an issue May 6, 2026 that may be closed by this pull request
@mkelley
mkelley requested a review from hhsieh00 May 6, 2026 14:50

@hhsieh00 hhsieh00 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkelley
mkelley merged commit b6e4519 into NASA-Planetary-Science:main May 14, 2026
10 checks passed
@mkelley
mkelley deleted the fix-doc-links-2026.05 branch May 14, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: intersphinx linking is broken

2 participants