Skip to content

Commit 05002e2

Browse files
NBForgeLab4ianD8H
authored
Fix conflict (#47)
* Fix potential crashes in the scene editor * Improve logs in case of UseAfterFreeError Only show in developer changelog * Fix potential crashes in the scene editor Don't show in changelog * Display extension details side by side with the extension list on large screens (4ian#8482) --------- Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: D8H <Davy.Helard@gmail.com>
1 parent 82b5cf7 commit 05002e2

9 files changed

Lines changed: 604 additions & 476 deletions

File tree

GDevelop.js/Bindings/postjs.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ function assertAlive(obj, label, gd, className) {
371371
if (!obj.ptr) {
372372
const destructionContext = obj._jsDestructionContext;
373373
if (destructionContext) {
374-
let message = `${label}: object (${className}) was already destroyed from JavaScript (ptr is 0, _jsDestructionContext is set).`;
374+
let message = `${label}: object was already destroyed from JavaScript (ptr is 0, _jsDestructionContext is set).`;
375375

376376
throw new UseAfterFreeError({
377377
message,
@@ -380,15 +380,17 @@ function assertAlive(obj, label, gd, className) {
380380
performance.now() - destructionContext.time
381381
),
382382
destroyedBy: destructionContext.stack,
383+
trackedClassName: className || undefined,
383384
},
384385
});
385386
} else {
386-
let message = `${label}: object (${className}) is a null pointer and might never have been alive (ptr is 0, _jsDestructionContext is not set).`;
387+
let message = `${label}: object is a null pointer and might never have been alive (ptr is 0, _jsDestructionContext is not set).`;
387388

388389
throw new UseAfterFreeError({
389390
message,
390391
useAfterFreeContext: {
391392
possiblyNeverAlive: true,
393+
trackedClassName: className || undefined,
392394
},
393395
});
394396
}

0 commit comments

Comments
 (0)