Unify dropped object naming with editor defaults

Author: NBForgeLab

.codex/environments/environment.toml

@@ -0,0 +1,15 @@
+# THIS IS AUTOGENERATED. DO NOT EDIT MANUALLY
+version = 1
+name = "GDevelop"
+
+[setup]
+script = ""
+
+[[actions]]
+name = "Run"
+icon = "run"
+command = '''
+cd "C:\Users\batah\OneDrive\المستندات\GitHub\GDevelop\newIDE\app"
+npm run build
+npm start
+'''

newIDE/app/src/ObjectsList/ObjectTypeDefaultName.js

@@ -0,0 +1,27 @@
+// @flow
+
+const objectTypeToDefaultName = {
+  Sprite: 'NewSprite',
+  'TiledSpriteObject::TiledSprite': 'NewTiledSprite',
+  'ParticleSystem::ParticleEmitter': 'NewParticlesEmitter',
+  'PanelSpriteObject::PanelSprite': 'NewPanelSprite',
+  'PrimitiveDrawing::Drawer': 'NewShapePainter',
+  'TextObject::Text': 'NewText',
+  'BBText::BBText': 'NewBBText',
+  'BitmapText::BitmapTextObject': 'NewBitmapText',
+  'TextEntryObject::TextEntry': 'NewTextEntry',
+  'TileMap::SimpleTileMap': 'NewTileMap',
+  'TileMap::TileMap': 'NewExternalTileMap',
+  'TileMap::CollisionMask': 'NewExternalTileMapMask',
+  'MyDummyExtension::DummyObject': 'NewDummyObject',
+  'Lighting::LightObject': 'NewLight',
+  'TextInput::TextInputObject': 'NewTextInput',
+  'Scene3D::Model3DObject': 'New3DModel',
+  'Scene3D::Cube3DObject': 'New3DBox',
+  'SpineObject::SpineObject': 'NewSpine',
+  'Video::VideoObject': 'NewVideo',
+};
+
+export const getDefaultObjectNameForType = (objectType: string): string =>
+  // $FlowFixMe[invalid-computed-prop]
+  objectTypeToDefaultName[objectType] || 'NewObject';

newIDE/app/src/ObjectsList/ObjectTypeDefaultName.spec.js

@@ -0,0 +1,15 @@
+// @flow
+import { getDefaultObjectNameForType } from './ObjectTypeDefaultName';
+
+describe('ObjectTypeDefaultName', () => {
+  it('returns the editor-style default object name for known object types', () => {
+    expect(getDefaultObjectNameForType('Sprite')).toBe('NewSprite');
+    expect(getDefaultObjectNameForType('PanelSpriteObject::PanelSprite')).toBe(
+      'NewPanelSprite'
+    );
+  });
+
+  it('falls back to NewObject for unknown object types', () => {
+    expect(getDefaultObjectNameForType('Unknown::Object')).toBe('NewObject');
+  });
+});

newIDE/app/src/ObjectsList/index.js

@@ -78,6 +78,7 @@ import {
   getDroppedSupportedFile,
   type DroppedSupportedFile,
 } from './DroppedFileObjectSelectorUtils';
+import { getDefaultObjectNameForType } from './ObjectTypeDefaultName';
 
 const gd: libGDevelop = global.gd;
 const nodePath = optionalRequire('path');
@@ -438,28 +439,6 @@ const getTreeViewItemRightButton = (i18n: I18nType) => (item: TreeViewItem) =>
 
 export const objectWithContextReactDndType = 'GD_OBJECT_WITH_CONTEXT';
 
-const objectTypeToDefaultName = {
-  Sprite: 'NewSprite',
-  'TiledSpriteObject::TiledSprite': 'NewTiledSprite',
-  'ParticleSystem::ParticleEmitter': 'NewParticlesEmitter',
-  'PanelSpriteObject::PanelSprite': 'NewPanelSprite',
-  'PrimitiveDrawing::Drawer': 'NewShapePainter',
-  'TextObject::Text': 'NewText',
-  'BBText::BBText': 'NewBBText',
-  'BitmapText::BitmapTextObject': 'NewBitmapText',
-  'TextEntryObject::TextEntry': 'NewTextEntry',
-  'TileMap::SimpleTileMap': 'NewTileMap',
-  'TileMap::TileMap': 'NewExternalTileMap',
-  'TileMap::CollisionMask': 'NewExternalTileMapMask',
-  'MyDummyExtension::DummyObject': 'NewDummyObject',
-  'Lighting::LightObject': 'NewLight',
-  'TextInput::TextInputObject': 'NewTextInput',
-  'Scene3D::Model3DObject': 'New3DModel',
-  'Scene3D::Cube3DObject': 'New3DBox',
-  'SpineObject::SpineObject': 'NewSpine',
-  'Video::VideoObject': 'NewVideo',
-};
-
 export type ObjectsListInterface = {|
   forceUpdateList: () => void,
   openNewObjectDialog: () => void,
@@ -712,21 +691,12 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
       ({
         objectType,
         resourceName,
-        sourceFileName,
       }: {|
         objectType: string,
         resourceName: string,
-        sourceFileName: string,
       |}) => {
-        const sourceBaseName = nodePath
-          ? nodePath.basename(sourceFileName, nodePath.extname(sourceFileName))
-          : sourceFileName.replace(/\.[^/.]+$/, '');
-        const fallbackName =
-          // $FlowFixMe[invalid-computed-prop]
-          objectTypeToDefaultName[objectType] || 'NewObject';
-        const defaultObjectName = sourceBaseName || fallbackName;
         const objectName = newNameGenerator(
-          defaultObjectName,
+          getDefaultObjectNameForType(objectType),
           candidateName =>
             objectsContainer.hasObjectNamed(candidateName) ||
             (!!globalObjectsContainer &&
@@ -912,8 +882,7 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
           ? 'New' +
             (project.getEventsBasedObject(objectType).getDefaultName() ||
               project.getEventsBasedObject(objectType).getName())
-          : // $FlowFixMe[invalid-computed-prop]
-            objectTypeToDefaultName[objectType] || 'NewObject';
+          : getDefaultObjectNameForType(objectType);
         const name = newNameGenerator(
           defaultName,
           name =>
@@ -1999,7 +1968,6 @@ const ObjectsList = React.forwardRef<Props, ObjectsListInterface>(
           insertObjectFromDroppedResource({
             objectType: objectTypeToCreate,
             resourceName,
-            sourceFileName: droppedFile.file.name,
           });
         } catch (error) {
           await showAlert({