Skip to content

Commit 4e13189

Browse files
committed
fix: remove server-specific nginx hint from key_exchange FAIL reason
1 parent 10e0eff commit 4e13189

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ $ quantumvalidator check cloudflare.com
1111
```
1212

1313
![Python](https://img.shields.io/badge/python-%3E%3D3.11-blue)
14-
![Tests](https://img.shields.io/badge/tests-205%20passing-brightgreen)
14+
![Tests](https://img.shields.io/badge/tests-206%20passing-brightgreen)
1515
![Coverage](https://img.shields.io/badge/coverage-100%25-brightgreen)
1616
![License](https://img.shields.io/badge/license-GPLv3-lightgrey)
1717

@@ -280,7 +280,7 @@ pytest tests/test_tls_utils.py
280280
pytest tests/test_assessor.py::TestAssessHttps -v
281281
```
282282

283-
The test suite has **205 tests** and maintains **100% statement coverage**.
283+
The test suite has **206 tests** and maintains **100% statement coverage**.
284284

285285
All network I/O (`openssl s_client` subprocess) is mocked at the `probe_tls` boundary —
286286
no test touches a real server or the internet.

quantumvalidator/verdict.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def build_checks(
9898
value=negotiated_group,
9999
reason=(
100100
f"No PQC hybrid group negotiated; got {negotiated_group or 'none'}. "
101-
"Configure X25519MLKEM768 support (OpenSSL 3.0+, nginx >= 1.27.1)."
101+
"Enable X25519MLKEM768 on the server (requires OpenSSL >= 3.0)."
102102
),
103103
standard="CNSA 2.0, BSI TR-02102-2",
104104
))

tests/test_verdict.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,12 @@ def test_fail_tls_check_has_standard(self):
6464
checks = build_checks("TLSv1.2", None)
6565
assert "CNSA 2.0" in (checks[0].standard or "")
6666

67+
def test_key_exchange_fail_reason_is_server_agnostic(self):
68+
checks = build_checks("TLSv1.3", "X25519")
69+
reason = checks[1].reason
70+
assert "nginx" not in reason.lower()
71+
assert "OpenSSL" in reason
72+
6773

6874
class TestDetermineVerdictSsh:
6975
def test_safe_mlkem768nistp256(self):

0 commit comments

Comments
 (0)