Metadata corrections from Fortran vs Metadata validation#1219
Merged
Conversation
climbfuji
marked this pull request as ready for review
May 20, 2026 20:16
climbfuji
requested review from
AndersJensen-NOAA,
dustinswales,
grantfirl,
haiqinli,
joeolson42,
lisa-bengtsson,
rhaesung and
tanyasmirnova
as code owners
May 20, 2026 20:16
dustinswales
approved these changes
May 20, 2026
dustinswales
left a comment
dustinswales
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for making these changes.
Collaborator
Author
|
ufs/dev pull request: ufs-community#375 |
grantfirl
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Metadata corrections from Fortran vs Metadata validation using an advanced version of the
ccpp-capgenvalidator.Disclaimer. I asked Claude/Opus to analyze the inconsistencies flagged by the validator, present the findings and then fix them. After that, I ran the validator again and all inconsistencies were gone.
ufs/devpull request: ufs-community#375Note. This set of changes is limited to
intent,kind, andoptionalcorrections. Additional changes will be introduced later regarding legacy dimension names etc. These require discussion and coordination in the CCPP physics management group. For now, I am using a legacy switch to allow these inconsistencies to pass through.Tests Conducted:
With these changes, the Fortran vs Metadata validation succeeds, and all suites present in CCPP-SCM (latest dev code) compile.
Dependencies:
None
Documentation:
None
Issue (optional):
None
Contributors (optional):
@dustinswales