fix: skip GitHub MCP smoke without token

rldyourmnd · rldyourmnd · commit 49803c423a71 · 2026-05-30T16:59:03.000+07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ The format follows Keep a Changelog, and marketplace/plugin versions follow Sema
 ## [Unreleased]
 
 
+## [1.1.11] - 2026-05-30
+
+### Fixed
+
+- Skip startup-required GitHub MCP smoke when token env is absent.
+
 ## [1.1.10] - 2026-05-30
 
 ### Fixed
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.1.10
+1.1.11
diff --git a/plugins/rldyour-browser/.codex-plugin/plugin.json b/plugins/rldyour-browser/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-browser",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Браузерная проверка и debug для Playwright/DevTools. EN: Browser validation and debugging workflows.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-design/.codex-plugin/plugin.json b/plugins/rldyour-design/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-design",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Дизайн/Figma/UI workflow с tokens, i18n, FSD и browser proof. EN: Design implementation workflows.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-explore/.codex-plugin/plugin.json b/plugins/rldyour-explore/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-explore",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Исследование docs, upstream и web evidence. EN: Technical and web research skills.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-flow/.codex-plugin/plugin.json b/plugins/rldyour-flow/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-flow",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Автономный SDLC Codex: ry-init/start/review/repair/deploy, hooks и sync. EN: SDLC workflow.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-lsps/.codex-plugin/plugin.json b/plugins/rldyour-lsps/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-lsps",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Маршрутизация LSP, health checks и Serena integration. EN: Language server workflow.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-mcps/.codex-plugin/plugin.json b/plugins/rldyour-mcps/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-mcps",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Управляемые MCP-серверы Codex без hidden transports. EN: Controlled MCP runtime set.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-rules/.codex-plugin/plugin.json b/plugins/rldyour-rules/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-rules",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Инженерные правила качества, architecture, deps, gates и ADR. EN: Quality-first engineering rules.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-security/.codex-plugin/plugin.json b/plugins/rldyour-security/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-security",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Безопасная реализация и defensive review. EN: OWASP and security review skills.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/plugins/rldyour-serena-mcp/.codex-plugin/plugin.json b/plugins/rldyour-serena-mcp/.codex-plugin/plugin.json
@@ -1,6 +1,6 @@
 {
   "name": "rldyour-serena-mcp",
-  "version": "1.1.10",
+  "version": "1.1.11",
   "description": "Код через Serena, memories, plans и research sync. EN: Serena MCP workflow skills.",
   "author": {
     "name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "rldyour-codex"
-version = "1.1.10"
+version = "1.1.11"
 description = "rldyour AI CLI configuration for Codex: plugin marketplace, system install, MCP servers, hooks, managed agents, runtime validation, and Serena memory."
 readme = "README.md"
 requires-python = ">=3.13,<3.14"
diff --git a/scripts/smoke_mcp_capabilities.py b/scripts/smoke_mcp_capabilities.py
@@ -32,6 +32,7 @@
 }
 
 AUTH_REQUIRED = {"figma"}
+STARTUP_ENV_REQUIRED = {"github"}
 
 
 class ProbeFailure(Exception):
@@ -152,6 +153,10 @@ def _merged_env(spec: dict[str, Any]) -> tuple[dict[str, str], list[str]]:
     return env, missing
 
 
+def _missing_forwarded_env(spec: dict[str, Any]) -> list[str]:
+    return [str(key) for key in spec.get("env_vars") or [] if os.environ.get(str(key)) is None]
+
+
 def _content_len(result: Any) -> int:
     content = getattr(result, "content", None)
     return len(content) if isinstance(content, list) else 0
@@ -315,6 +320,12 @@ async def _probe_server(
 ) -> tuple[str, str]:
     if name in AUTH_REQUIRED and not include_auth:
         return "skip", f"{name}: auth-required MCP skipped; use --include-auth to probe it"
+    missing_env = _missing_forwarded_env(spec)
+    if missing_env and name in STARTUP_ENV_REQUIRED:
+        message = f"{name}: startup skipped; missing env: {', '.join(missing_env)}"
+        if allow_missing_env:
+            return "skip", message
+        raise ProbeFailure(message)
 
     async def body(session: ClientSession, missing_env: list[str]) -> None:
         if missing_env and not allow_missing_env:
diff --git a/tests/unit/test_smoke_mcp_capabilities.py b/tests/unit/test_smoke_mcp_capabilities.py
@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import json
+import os
 import subprocess
 import sys
 from pathlib import Path
@@ -54,3 +55,50 @@ def test_static_mode_parses_repo_config_without_installed_codex_home(
     assert payload["count"] == 2
     assert payload["errors"] == []
     assert {item["server"] for item in payload["results"]} == {"serena", "openaiDeveloperDocs"}
+
+
+def test_allow_missing_env_skips_startup_required_github(tmp_path: Path) -> None:
+    mcp_dir = tmp_path / "plugins" / "rldyour-mcps"
+    mcp_dir.mkdir(parents=True)
+    github_spec = {
+        "command": "/bin/false",
+        "env_vars": ["GITHUB_PERSONAL_ACCESS_TOKEN"],
+    }
+    (mcp_dir / ".mcp.json").write_text(
+        json.dumps({"mcpServers": {"github": github_spec}}),
+        encoding="utf-8",
+    )
+    codex_home = tmp_path / "codex-home"
+    codex_home.mkdir()
+    (codex_home / "config.toml").write_text(
+        """
+[mcp_servers.github]
+command = "/bin/false"
+env_vars = ["GITHUB_PERSONAL_ACCESS_TOKEN"]
+""".lstrip(),
+        encoding="utf-8",
+    )
+    env = os.environ.copy()
+    env.pop("GITHUB_PERSONAL_ACCESS_TOKEN", None)
+
+    proc = subprocess.run(
+        [
+            sys.executable,
+            str(REPO_ROOT / "scripts" / "smoke_mcp_capabilities.py"),
+            "--root",
+            str(tmp_path),
+            "--codex-home",
+            str(codex_home),
+            "--allow-missing-env",
+            "--server",
+            "github",
+        ],
+        text=True,
+        capture_output=True,
+        check=False,
+        timeout=10,
+        env=env,
+    )
+
+    assert proc.returncode == 0, proc.stderr
+    assert "skip    github: startup skipped; missing env: GITHUB_PERSONAL_ACCESS_TOKEN" in proc.stdout
diff --git a/uv.lock b/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-browser",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Браузерная проверка и debug для Playwright/DevTools. EN: Browser validation and debugging workflows.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-design",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Дизайн/Figma/UI workflow с tokens, i18n, FSD и browser proof. EN: Design implementation workflows.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-explore",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Исследование docs, upstream и web evidence. EN: Technical and web research skills.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-flow",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Автономный SDLC Codex: ry-init/start/review/repair/deploy, hooks и sync. EN: SDLC workflow.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-lsps",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Маршрутизация LSP, health checks и Serena integration. EN: Language server workflow.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-mcps",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Управляемые MCP-серверы Codex без hidden transports. EN: Controlled MCP runtime set.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-rules",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Инженерные правила качества, architecture, deps, gates и ADR. EN: Quality-first engineering rules.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rldyour-security",`
`3`		`- "version": "1.1.10",`
	`3`	`+ "version": "1.1.11",`
`4`	`4`	`"description": "Безопасная реализация и defensive review. EN: OWASP and security review skills.",`
`5`	`5`	`"author": {`
`6`	`6`	`"name": "Danil Silantyev (github:rldyourmnd), CEO NDDev",`