Refactor OTLPMetricsClient to use ESQL with TS and use CSV Streaming#13
Draft
martialblog wants to merge 1 commit into
Draft
Refactor OTLPMetricsClient to use ESQL with TS and use CSV Streaming#13martialblog wants to merge 1 commit into
martialblog wants to merge 1 commit into
Conversation
martialblog
force-pushed
the
refactor/esql-csv
branch
from
60fbd48 to
bcccbf6
Compare
martialblog
commented
Jul 7, 2026
| $req = new Request($method, $uri, [], $body); | ||
|
|
||
| $response = $this->transport->sendRequest($req, true); | ||
| // TODO: Error handling |
Member
Author
There was a problem hiding this comment.
We need to check the return code, since the data is now either CSV if things go well, or JSON if there's an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.