Skip to content

Refactor OTLPMetricsClient to use aggregations#9

Open
martialblog wants to merge 1 commit into
mainfrom
refactor/aggregations
Open

Refactor OTLPMetricsClient to use aggregations#9
martialblog wants to merge 1 commit into
mainfrom
refactor/aggregations

Conversation

@martialblog

@martialblog martialblog commented Apr 29, 2026

Copy link
Copy Markdown
Member

This would allow for the maxdatapoints pattern we use in other Perfdata Backends.

TODO:

  • I think there is still a bug when there are periods of no data

@martialblog martialblog force-pushed the refactor/aggregations branch from d3ae2d3 to 6e82412 Compare April 29, 2026 12:10
@martialblog martialblog self-assigned this Apr 29, 2026
@martialblog martialblog marked this pull request as ready for review April 29, 2026 12:12
@martialblog martialblog marked this pull request as draft April 29, 2026 17:35
@martialblog martialblog added this to the v0.1.0 milestone Jun 18, 2026
@martialblog

Copy link
Copy Markdown
Member Author

Also fails when there's too much data:

Error while fetching data: {"root_cause":[],"type":"search_phase_execution_exception","reason":"","phase":"fetch","grouped":true,"failed_shards":[],"caused_by":{"type":"too_many_buckets_exception","reason":"Trying to create too many buckets. Must be less than or equal to: [65536] but this number of buckets was exceeded. This limit can be set by changing the [search.max_buckets] cluster level setting.","max_buckets":65536}} No data received.

@martialblog martialblog modified the milestones: v0.1.0, v0.2.0 Jun 18, 2026
@martialblog martialblog force-pushed the refactor/aggregations branch from c34ee46 to c0126ce Compare June 18, 2026 15:05
@martialblog

Copy link
Copy Markdown
Member Author

Tried to improve the query: https://github.com/NETWAYS/icingaweb2-module-perfdatagraphs-elasticsearch/tree/experiment-aggs

The PerfdataReponse isn't correct yet, but so far no " too many buckets" error.

@martialblog martialblog force-pushed the refactor/aggregations branch from c0126ce to 526e677 Compare July 6, 2026 12:07
@martialblog martialblog marked this pull request as ready for review July 6, 2026 12:07
@martialblog martialblog force-pushed the refactor/aggregations branch from 526e677 to d2ab5c9 Compare July 6, 2026 12:52
@martialblog martialblog modified the milestones: v0.2.0, v0.1.0 Jul 6, 2026
@martialblog martialblog force-pushed the refactor/aggregations branch from d2ab5c9 to e5fe8d8 Compare July 6, 2026 13:41
@martialblog martialblog removed this from the v0.1.0 milestone Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant