-
Notifications
You must be signed in to change notification settings - Fork 0
16 add new extension methods #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
junc-nf
wants to merge
4
commits into
master
Choose a base branch
from
16-add-new-extension-methods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9056a56
Support negative steps in ListDaysTo; add unit tests
junc-nf bdd8e87
Add DeserializeAnonymousType extension and unit tests
junc-nf 3466cea
Implement GetPropertyAttribute, GetValueAttribute, and GetTypeAttribu…
junc-nf 72b5b79
Fix grammar
junc-nf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -239,10 +239,13 @@ private static DateOnly GetXthDayInMonth(this IEnumerable<DateOnly> days, int xt | |
| /// </summary> | ||
| /// <param name="start">The date to start at.</param> | ||
| /// <param name="end">The date to end at.</param> | ||
| /// <param name="step">The number of days use as an interval.</param> | ||
| /// <param name="step">The number of days used as an interval. Use a negative value to iterate in reverse.</param> | ||
| public static IEnumerable<DateTime> ListDaysTo(this DateTime start, DateTime end, int step = 1) | ||
| { | ||
| for (var day = start.Date; day.Date <= end.Date; day = day.AddDays(step)) | ||
| if (step == 0) | ||
| yield break; | ||
|
Comment on lines
+245
to
+246
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't seem necessary? Need confirmation from @thirstyape |
||
|
|
||
| for (var day = start.Date; step > 0 ? day.Date <= end.Date : day.Date >= end.Date; day = day.AddDays(step)) | ||
| yield return day; | ||
| } | ||
|
|
||
|
|
@@ -251,10 +254,13 @@ public static IEnumerable<DateTime> ListDaysTo(this DateTime start, DateTime end | |
| /// </summary> | ||
| /// <param name="start">The date to start at.</param> | ||
| /// <param name="end">The date to end at.</param> | ||
| /// <param name="step">The number of days use as an interval.</param> | ||
| /// <param name="step">The number of days used as an interval. Use a negative value to iterate in reverse.</param> | ||
| public static IEnumerable<DateOnly> ListDaysTo(this DateOnly start, DateOnly end, int step = 1) | ||
| { | ||
| for (var day = start; day <= end; day = day.AddDays(step)) | ||
| if (step == 0) | ||
| yield break; | ||
|
Comment on lines
+260
to
+261
|
||
|
|
||
| for (var day = start; step > 0 ? day <= end : day >= end; day = day.AddDays(step)) | ||
| yield return day; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.