Skip to content

[ERSSUP-82767]-[]-[Initial OAS modelling form RM106]-[DMW] - #1908

Open
nhsd-david-wass wants to merge 1 commit into
developfrom
feature/ERSSUP-82767
Open

[ERSSUP-82767]-[]-[Initial OAS modelling form RM106]-[DMW]#1908
nhsd-david-wass wants to merge 1 commit into
developfrom
feature/ERSSUP-82767

Conversation

@nhsd-david-wass

Copy link
Copy Markdown
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@nhsd-david-wass
nhsd-david-wass requested a review from a team as a code owner February 10, 2025 09:25
type: string
enum:
- statusChanged
valueDateTime:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would want this as an [instant|https://hl7.org/fhir/R4/datatypes.html#instant] as in FHIR a dataTime can be a partial dateTime which I don't think we would want. @nhsd-jack-wainwright do you agree?

type: string
enum:
- 'https://fhir.nhs.uk/CodeSystem/eRS-ReferralCancellationReason'
example: 'https://fhir.nhs.uk/CodeSystem/eRS-ReferralCancellationReason'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about naming.

Are the e-RS Appointment Request Cancellation Reasons used for A&G too?

Just thinking in the FHIR world this is a ServiceRequest. If the e-RS reasons are used for A&G too then maybe this is just RequestCancellationReason?

},
"extension": [
{
"url": "https://fhir.nhs.uk/StructureDefinition/Extension-Portal-Link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a cancelled request would have the portal link as you can't see cancelled referrals in MYR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example doesn't fully make sense at the minute as you have a cancelled ServiceRequest that has an Appointment associated.

I wonder if it would be better just to update/extend the existing example (ServiceRequestsWithAppointmentAndTask.json) to add in one additional ServiceRequest that is in the cancelled state. This wouldn't have any related Appointment or Task. Also no portal link.

- CARL
- ARBL
- CARBL_OR_ARL
- CANCELLED_REFERRAL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the core enum wouldn't this just be CANCELLED?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants