Skip to content

Commit de4d3ab

Browse files
simplified the NBS covid config to allow too close suitability rule to be triggered via a single config.
update vaccination dates to align with the above on 2 scenarios updated expected response for the above 2 scenarios to align with vaccs date
1 parent 702373d commit de4d3ab

7 files changed

Lines changed: 12 additions & 299 deletions

File tree

data/configs/nbsIntegrationTestConfigs/NBS_COVID_Config_Spring2026_v1.1.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
"IterationFrequency": "X",
1818
"IterationType": "O",
1919
"IterationTime": "07:00:00",
20-
"StartDate": "<<DATE_DAY_-100>>",
21-
"EndDate": "<<DATE_DAY_+100>>",
20+
"StartDate": "<<DATE_DAY_-89>>",
21+
"EndDate": "<<DATE_DAY_+89>>",
2222
"ApprovalMinimum": 0,
2323
"ApprovalMaximum": 0,
2424
"DefaultCommsRouting": "BOOK_NBS",
@@ -30,7 +30,7 @@
3030
"DefaultNotEligibleRouting": "",
3131
"Version": 1,
3232
"Name": "EliD NBS COVID-19 campaign config Release 1",
33-
"IterationDate": "<<DATE_DAY_-100>>",
33+
"IterationDate": "<<DATE_DAY_-89>>",
3434
"IterationNumber": 1,
3535
"CommsType": "I",
3636
"ApprovalMinimum": 0,
@@ -89,7 +89,7 @@
8989
"Name": "Remove from magic cohort unless already vaccinated or have future booking",
9090
"Description": "Remove anyone NOT already vaccinated within the current campaign and do not have a future booking from the magic cohort",
9191
"Operator": "<",
92-
"Comparator": "<<DATE_DAY_-93>>[[NVL:18000101]]",
92+
"Comparator": "<<DATE_DAY_-89>>[[NVL:18000101]]",
9393
"AttributeTarget": "COVID",
9494
"AttributeLevel": "TARGET",
9595
"AttributeName": "LAST_SUCCESSFUL_DATE",
@@ -124,7 +124,7 @@
124124
"Name": "Remove from eligible cohorts if already vaccinated",
125125
"Description": "Remove anyone already vaccinated in current campaign from eligible cohorts",
126126
"Operator": ">=",
127-
"Comparator": "<<DATE_DAY_-93>>",
127+
"Comparator": "<<DATE_DAY_-89>>",
128128
"AttributeTarget": "COVID",
129129
"AttributeLevel": "TARGET",
130130
"AttributeName": "LAST_SUCCESSFUL_DATE",
@@ -140,7 +140,7 @@
140140
"AttributeTarget": "COVID",
141141
"AttributeName": "LAST_SUCCESSFUL_DATE",
142142
"Operator": ">=",
143-
"Comparator": "<<DATE_DAY_-93>>",
143+
"Comparator": "<<DATE_DAY_-89>>",
144144
"RuleStop": "Y"
145145
},
146146
{
@@ -223,7 +223,7 @@
223223
"AttributeTarget": "COVID",
224224
"AttributeName": "LAST_SUCCESSFUL_DATE",
225225
"Operator": ">=",
226-
"Comparator": "<<DATE_DAY_-93>>",
226+
"Comparator": "<<DATE_DAY_-89>>",
227227
"CommsRouting": "LAST_VACCINATION_DATE"
228228
},
229229
{

data/configs/nbsIntegrationTestConfigs/NBS_COVID_Config_Spring2026_v1.1_too_close.json

Lines changed: 0 additions & 287 deletions
This file was deleted.

data/dynamoDB/nbsIntegrationTestData/AUTO_COVID_NBS_INT_NA01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
{
3535
"NHS_NUMBER": "5998800788",
3636
"ATTRIBUTE_TYPE": "COVID",
37-
"LAST_SUCCESSFUL_DATE": "<<DATE_DAY_-92>>"
37+
"LAST_SUCCESSFUL_DATE": "<<DATE_DAY_-50>>"
3838
}
3939
]
4040
}

data/dynamoDB/nbsIntegrationTestData/AUTO_COVID_NBS_INT_NA02.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"nhsd-End-User-Organisation-ods": "elid_automation"
66
},
77
"config_filenames": [
8-
"NBS_COVID_Config_Spring2026_v1.1_too_close.json"
8+
"NBS_COVID_Config_Spring2026_v1.1.json"
99
],
1010
"data": [
1111
{

data/dynamoDB/nbsIntegrationTestData/AUTO_COVID_NBS_INT_NA03.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
{
1818
"NHS_NUMBER": "9454350900",
1919
"ATTRIBUTE_TYPE": "COVID",
20-
"LAST_SUCCESSFUL_DATE": "<<DATE_DAY_-92>>"
20+
"LAST_SUCCESSFUL_DATE": "<<DATE_DAY_-50>>"
2121
},
2222
{
2323
"NHS_NUMBER": "9454350900",

data/responses/nbsIntegrationTestResponses/AUTO_COVID_NBS_INT_NA01.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
{
99
"actionCode": "DateOfLastVaccination",
1010
"actionType": "DataValue",
11-
"description": "<<NBSDATE_DAY_-92>>",
11+
"description": "<<NBSDATE_DAY_-50>>",
1212
"urlLabel": "",
1313
"urlLink": ""
1414
}

data/responses/nbsIntegrationTestResponses/AUTO_COVID_NBS_INT_NA03.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
{
99
"actionCode": "DateOfLastVaccination",
1010
"actionType": "DataValue",
11-
"description": "<<NBSDATE_DAY_-92>>",
11+
"description": "<<NBSDATE_DAY_-50>>",
1212
"urlLabel": "",
1313
"urlLink": ""
1414
}

0 commit comments

Comments
 (0)