Respond to unknown actions with error and message

Author: steventux

src/relay_listener.py

@@ -107,7 +107,8 @@ def process_action(self, payload: dict):
         elif action_name == "worklist.update_status":
             return UpdateWorklistItemStatus(self.storage).call(payload)
         else:
-            raise ValueError(f"Unsupported action: {action_name}")
+            logger.error("Unsupported action: %s", action_name)
+            return {"status": "error", "message": f"Unsupported action: {action_name}"}
 
     def _connect(self):
         """Connect to Azure Relay."""

tests/test_relay_listener.py

@@ -159,15 +159,13 @@ def test_process_action_invalid_type(self, storage_instance, listener_payload):
 
         listener_payload["action_type"] = "worklist.unknown_action"
 
-        with pytest.raises(ValueError):
-            response = subject.process_action(listener_payload)
-            assert response == {
-                "status": "error",
-                "action_id": "action-12345",
-                "error": "Unknown action type: worklist.unknown_action",
-            }
-
-            storage_instance.store_worklist_item.assert_not_called()
+        response = subject.process_action(listener_payload)
+        assert response == {
+            "status": "error",
+            "message": "Unsupported action: worklist.unknown_action",
+        }
+
+        storage_instance.store_worklist_item.assert_not_called()
 
 
 class TestRelayURIWithDefaultAzureCredential: