Filter completed and discontinued worklist items

There's no point in returning worklist items for a C-FIND query when they have been completed or discontinued.

Author: steventux

src/services/storage.py

@@ -367,7 +367,7 @@ def find_worklist_items(
             "source_message_id, study_description, study_instance_uid, status, mpps_instance_uid "
             "FROM worklist_items"
         )
-        where_clauses = []
+        where_clauses = ["status NOT IN ('COMPLETED', 'DISCONTINUED')"]
         params = []
 
         if accession_number:

tests/services/test_storage.py

@@ -229,6 +229,34 @@ def test_find_worklist_items_patient_name_wildcard_conversion(self, mwl_storage,
         assert len(results) == 1
         assert results[0].patient_name == "SMITH^JANE"
 
+    def test_find_worklist_items_with_filters_completed_items(self, mwl_storage, result):
+        item = self._insert_item(mwl_storage, result)
+        mwl_storage.update_status(item.accession_number, "IN PROGRESS")
+        mwl_storage.update_status(item.accession_number, "COMPLETED")
+
+        results = mwl_storage.find_worklist_items(
+            accession_number="ACC123456",
+            modality="MG",
+            scheduled_date="20240101",
+            patient_id="999123456",
+        )
+
+        assert len(results) == 0
+
+    def test_find_worklist_items_with_filters_discontinued_items(self, mwl_storage, result):
+        item = self._insert_item(mwl_storage, result)
+        mwl_storage.update_status(item.accession_number, "IN PROGRESS")
+        mwl_storage.update_status(item.accession_number, "DISCONTINUED")
+
+        results = mwl_storage.find_worklist_items(
+            accession_number="ACC123456",
+            modality="MG",
+            scheduled_date="20240101",
+            patient_id="999123456",
+        )
+
+        assert len(results) == 0
+
     def test_get_worklist_item(self, mwl_storage, result):
         item = self._insert_item(mwl_storage, result)