Use relay message status in response

We don't want to replay the status we've set on the worklist item, we want a message status from the gateway so we can update the GatewayAction used in this relay communication.

Author: steventux

src/services/mwl/update_worklist_item_status.py

@@ -17,7 +17,7 @@ def call(self, payload: dict):
             if updated_item is None:
                 return {"status": "error", "message": f"Worklist item '{accession_number}' not found"}
 
-            return {"accession_number": accession_number, "status": status}
+            return {"accession_number": accession_number, "status": "confirmed"}
         except KeyError as e:
             return {"status": "error", "message": f"Missing key: {e}"}
         except Exception as e:

src/services/storage.py

@@ -463,7 +463,7 @@ def update_status(
         Transition a worklist item to a new status, enforcing valid state transitions.
 
         Args:
-            accession_number: The accession number to update
+            accession_number: The accession number of the worklist item to update
             status: Target status
             mpps_instance_uid: Optional MPPS instance UID
 

tests/integration/test_relay_listener_processes_actions.py

@@ -56,7 +56,7 @@ async def test_relay_listener_updates_worklist_item_status(self, update_payload,
         with fake_relay(relay_message, json.dumps(update_payload)) as ws_client:
             await listener.listen()
 
-        ws_client.send.assert_called_once_with(json.dumps({"accession_number": "ACC999999", "status": "IN PROGRESS"}))
+        ws_client.send.assert_called_once_with(json.dumps({"accession_number": "ACC999999", "status": "confirmed"}))
         stored_items = storage.find_worklist_items()
         assert len(stored_items) == 1
         item = stored_items[0]

tests/services/mwl/test_update_worklist_item_status.py

@@ -41,7 +41,7 @@ def test_call_success(self, mwl_storage, worklist_item_data, status_update_paylo
 
         subject = UpdateWorklistItemStatus(mwl_storage)
         response = subject.call(status_update_payload)
-        assert response == {"accession_number": "ACC123", "status": "COMPLETED"}
+        assert response == {"accession_number": "ACC123", "status": "confirmed"}
 
     def test_call_missing_keys(self, mwl_storage, status_update_payload):
         subject = UpdateWorklistItemStatus(mwl_storage)

tests/test_relay_listener.py

@@ -105,7 +105,7 @@ def test_process_update_item_status_action(self, storage_instance, listener_payl
         }
 
         response = subject.process_action(update_payload)
-        assert response == {"accession_number": "ACC999999", "status": "IN PROGRESS"}
+        assert response == {"accession_number": "ACC999999", "status": "confirmed"}
 
         storage_instance.update_status.assert_called_once_with("ACC999999", "IN PROGRESS")