Amend DuplicateWorklistItemError to WorklistItemExistsError

Author: steventux

src/services/storage.py

@@ -291,7 +291,7 @@ class InvalidStatusTransitionError(Exception):
     pass
 
 
-class DuplicateWorklistItemError(Exception):
+class WorklistItemExistsError(Exception):
     """Raised when a worklist item with the same accession number already exists."""
 
     pass
@@ -346,7 +346,7 @@ def store_worklist_item(
                 )
                 conn.commit()
         except sqlite3.IntegrityError:
-            raise DuplicateWorklistItemError(f"Worklist item already exists: {worklist_item.accession_number}")
+            raise WorklistItemExistsError(f"Worklist item already exists: {worklist_item.accession_number}")
 
         return worklist_item.accession_number
 

tests/services/test_storage.py

@@ -6,7 +6,13 @@
 from pydicom.uid import generate_uid
 
 from models import WorklistItem
-from services.storage import InvalidStatusTransitionError, MWLStorage, PACSStorage, WorklistItemNotFoundError
+from services.storage import (
+    InvalidStatusTransitionError,
+    MWLStorage,
+    PACSStorage,
+    WorklistItemExistsError,
+    WorklistItemNotFoundError,
+)
 
 
 @pytest.fixture
@@ -136,6 +142,13 @@ def test_store_worklist_item(self, mwl_storage, result):
         assert row is not None
         assert row["patient_id"] == item.patient_id
 
+    def test_store_worklist_item_already_exists(self, mwl_storage, result):
+        item = WorklistItem(**result)
+        mwl_storage.store_worklist_item(item)
+
+        with pytest.raises(WorklistItemExistsError):
+            mwl_storage.store_worklist_item(item)
+
     def test_find_worklist_items(self, mwl_storage, result):
         item = self._insert_item(mwl_storage, result)