Ensure patient name is used to process test items

Safeguard against accidentally processing items without a patient name in the C-FIND criteria. This ensures processing test items are correctly scoped.

Author: steventux

src/relay_listener.py

@@ -104,19 +104,14 @@ def process_action(self, payload: dict):
             result = CreateWorklistItem(self.storage).call(payload)
             patient_name = payload.get("parameters", {}).get("worklist_item", {}).get("participant", {}).get("name")
 
-            def _run_emulator():
-                try:
-                    self.process_with_modality_emulator(patient_name=patient_name)
-                except Exception:
-                    logger.exception("Modality emulator processing failed")
+            if not patient_name:
+                logger.warning("No patient name provided for ModalityEmulator test item processing")
+                return {
+                    "status": "error",
+                    "message": "No patient name provided for ModalityEmulator test item processing",
+                }
 
-            try:
-                loop = asyncio.get_running_loop()
-            except RuntimeError:
-                # Called outside an event loop (e.g. unit tests)
-                _run_emulator()
-            else:
-                loop.create_task(asyncio.to_thread(_run_emulator))
+            self.process_with_modality_emulator(patient_name=patient_name)
 
             return result
         elif action_name == "worklist.update_status":
@@ -138,7 +133,19 @@ def process_with_modality_emulator(self, patient_name: str | None = None):
         ae.add_requested_context(DigitalMammographyXRayImageStorageForPresentation)
         ae.add_requested_context(ModalityWorklistInformationFind)
 
-        ModalityEmulator(self.storage).process_worklist_items(ae, patient_name=patient_name)
+        def _run_emulator():
+            try:
+                ModalityEmulator(self.storage).process_worklist_items(ae, patient_name=patient_name)
+            except Exception:
+                logger.exception("Modality emulator processing failed")
+
+        try:
+            loop = asyncio.get_running_loop()
+        except RuntimeError:
+            # Called outside an event loop (e.g. unit tests)
+            _run_emulator()
+        else:
+            loop.create_task(asyncio.to_thread(_run_emulator))
 
 
 class RelayURI:

tests/test_relay_listener.py

@@ -143,6 +143,23 @@ def test_process_create_test_item_action_triggers_modality_emulator(self, storag
             )
         )
 
+    def test_process_create_test_item_action_without_patient_name_returns_error(
+        self, storage_instance, listener_payload
+    ):
+        """Process create test item action without a patient name returns an error."""
+        subject = RelayListener(storage_instance)
+        payload = dict(listener_payload)
+        payload["action_type"] = "worklist.create_test_item"
+        del payload["parameters"]["worklist_item"]["participant"]["name"]
+
+        with patch.object(subject, "process_with_modality_emulator"):
+            response = subject.process_action(payload)
+
+        assert response == {
+            "status": "error",
+            "message": "No patient name provided for ModalityEmulator test item processing",
+        }
+
     def test_process_action_missing_keys(self, storage_instance, listener_payload):
         """Process action missing keys."""
         subject = RelayListener(storage_instance)