Raise when update/delete by accession number fails to find record

Author: steventux

src/services/storage.py

@@ -206,6 +206,12 @@ class WorklistItem:
     )
 
 
+class WorklistItemNotFoundError(Exception):
+    """Raised when a worklist item is not found in storage."""
+
+    pass
+
+
 class MWLStorage(Storage):
     def __init__(self, db_path: str = "/var/lib/pacs/worklist.db"):
         """
@@ -379,7 +385,10 @@ def update_study_instance_uid(self, accession_number: str, study_instance_uid: s
             )
             conn.commit()
 
-            return cursor.rowcount > 0
+            if cursor.rowcount == 0:
+                raise WorklistItemNotFoundError(f"Worklist item not found: {accession_number}")
+
+            return True
 
     def delete_worklist_item(self, accession_number: str) -> bool:
         """
@@ -389,9 +398,13 @@ def delete_worklist_item(self, accession_number: str) -> bool:
             accession_number: The accession number to delete
 
         Returns:
-            True if item was deleted, False if not found
+            True if item was deleted, raises WorklistItemNotFoundError if not found
         """
         with self._get_connection() as conn:
             cursor = conn.execute("DELETE FROM worklist_items WHERE accession_number = ?", (accession_number,))
             conn.commit()
-            return cursor.rowcount > 0
+
+            if cursor.rowcount == 0:
+                raise WorklistItemNotFoundError(f"Worklist item not found: {accession_number}")
+
+            return True

tests/services/test_storage.py

@@ -5,7 +5,7 @@
 import pytest
 from pydicom.uid import generate_uid
 
-from services.storage import MWLStorage, PACSStorage, WorklistItem
+from services.storage import MWLStorage, PACSStorage, WorklistItem, WorklistItemNotFoundError
 
 
 @patch("services.storage.sqlite3")
@@ -424,6 +424,20 @@ def test_update_study_instance_uid(self, mock_db, tmp_dir):
 
         assert result is True
 
+    def test_update_study_instance_uid_raises(self, mock_db, tmp_dir):
+        study_instance_uid = "some-uid"
+        mock_connection = MagicMock()
+        mock_cursor = PropertyMock()
+        mock_cursor.rowcount = 0
+        mock_connection.execute.return_value = mock_cursor
+        mock_db.connect.return_value = mock_connection
+
+        subject = MWLStorage(tmp_dir)
+        mock_connection.reset_mock()
+
+        with pytest.raises(WorklistItemNotFoundError):
+            subject.update_study_instance_uid("ACC123456", study_instance_uid)
+
     def test_delete_worklist_item(self, mock_db, tmp_dir):
         mock_connection = MagicMock()
         mock_cursor = PropertyMock()
@@ -442,3 +456,16 @@ def test_delete_worklist_item(self, mock_db, tmp_dir):
         mock_connection.commit.assert_called_once()
 
         assert result is True
+
+    def test_delete_worklist_item_raises(self, mock_db, tmp_dir):
+        mock_connection = MagicMock()
+        mock_cursor = PropertyMock()
+        mock_cursor.rowcount = 0
+        mock_connection.execute.return_value = mock_cursor
+        mock_db.connect.return_value = mock_connection
+
+        subject = MWLStorage(tmp_dir)
+        mock_connection.reset_mock()
+
+        with pytest.raises(WorklistItemNotFoundError):
+            subject.delete_worklist_item("ACC123456")