Skip to content

Commit f814764

Browse files
fix merge errors
1 parent 20284b7 commit f814764

2 files changed

Lines changed: 28 additions & 11 deletions

File tree

tests/services/mwl/test_c_find.py

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,12 @@ def test_call_with_accession_number_filter(self, handler, mock_storage, mock_eve
114114
list(handler.call(mock_event))
115115

116116
mock_storage.find_worklist_items.assert_called_once_with(
117-
accession_number="ACC12345", modality=None, scheduled_date=None, scheduled_time=None, patient_id=None
117+
accession_number="ACC12345",
118+
modality=None,
119+
scheduled_date=None,
120+
scheduled_time=None,
121+
patient_id=None,
122+
patient_name=None,
118123
)
119124

120125
def test_call_with_modality_filter(self, handler, mock_storage, mock_event):
@@ -144,7 +149,12 @@ def test_call_with_date_filter(self, handler, mock_storage, mock_event):
144149
list(handler.call(mock_event))
145150

146151
mock_storage.find_worklist_items.assert_called_once_with(
147-
accession_number=None, modality=None, scheduled_date="20260107", scheduled_time=None, patient_id=None
152+
accession_number=None,
153+
modality=None,
154+
scheduled_date="20260107",
155+
scheduled_time=None,
156+
patient_id=None,
157+
patient_name=None,
148158
)
149159

150160
def test_call_with_time_filter(self, handler, mock_storage, mock_event):
@@ -159,7 +169,7 @@ def test_call_with_time_filter(self, handler, mock_storage, mock_event):
159169
accession_number=None,
160170
scheduled_time="100000",
161171
modality=None,
162-
scheduled_date="20260107",
172+
scheduled_date=None,
163173
patient_id=None,
164174
patient_name=None,
165175
)
@@ -186,7 +196,12 @@ def test_call_with_patient_name_filter(self, handler, mock_storage, mock_event):
186196
list(handler.call(mock_event))
187197

188198
mock_storage.find_worklist_items.assert_called_once_with(
189-
modality=None, scheduled_date=None, patient_id=None, patient_name="Smith*"
199+
accession_number=None,
200+
modality=None,
201+
scheduled_date=None,
202+
scheduled_time=None,
203+
patient_id=None,
204+
patient_name="Smith*",
190205
)
191206

192207
def test_call_handles_storage_exception(self, handler, mock_storage, mock_event):

tests/services/test_storage.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -421,15 +421,17 @@ def test_find_worklist_items_with_date_and_time_range(self, mock_db, tmp_dir):
421421
)
422422

423423
@pytest.mark.parametrize(
424-
"dicom_pattern, sql_pattern",
424+
"dicom_pattern, sql_pattern, operator",
425425
[
426-
("Smith*", "Smith%"), # trailing wildcard
427-
("*Smith*", "%Smith%"), # leading and trailing wildcard
428-
("Sm?th*", "Sm_th%"), # single-character wildcard combined with trailing
429-
("Smith^Jane", "Smith^Jane"), # exact name, no wildcards
426+
("Smith*", "Smith%", "LIKE"), # trailing wildcard
427+
("*Smith*", "%Smith%", "LIKE"), # leading and trailing wildcard
428+
("Sm?th*", "Sm_th%", "LIKE"), # single-character wildcard combined with trailing
429+
("Smith^Jane", "Smith^Jane", "="), # exact name, no wildcards — uses = not LIKE
430430
],
431431
)
432-
def test_find_worklist_items_patient_name_wildcard_conversion(self, mock_db, tmp_dir, dicom_pattern, sql_pattern):
432+
def test_find_worklist_items_patient_name_wildcard_conversion(
433+
self, mock_db, tmp_dir, dicom_pattern, sql_pattern, operator
434+
):
433435
mock_cursor = MagicMock()
434436
mock_cursor.fetchall.return_value = []
435437
mock_connection = MagicMock()
@@ -445,7 +447,7 @@ def test_find_worklist_items_patient_name_wildcard_conversion(self, mock_db, tmp
445447
"SELECT accession_number, modality, patient_birth_date, patient_id, "
446448
"patient_name, patient_sex, procedure_code, scheduled_date, scheduled_time, "
447449
"source_message_id, study_description, study_instance_uid, status, mpps_instance_uid "
448-
"FROM worklist_items WHERE UPPER(patient_name) LIKE UPPER(?) ORDER BY scheduled_date, scheduled_time"
450+
f"FROM worklist_items WHERE UPPER(patient_name) {operator} UPPER(?) ORDER BY scheduled_date, scheduled_time"
449451
),
450452
[sql_pattern],
451453
)

0 commit comments

Comments
 (0)