Fix case of screening_entra_group_id in prod tfvars (#166)

carlosmartinez · web-flow · commit f8383b14f6b3 · 2026-07-16T12:49:32.000+01:00
Terraform variable names are case-sensitive: prod's tfvars set
SCREENING_ENTRA_GROUP_ID, which Terraform ignores as an undeclared
variable, leaving the required screening_entra_group_id unset. The
next prod arc-infra plan would fail with "No value for required
variable". Lowercase it to match the variable declaration and every
other environment.

Also remove the duplicate from variables.sh: nothing consumes it from
the shell environment.
diff --git a/infrastructure/environments/prod/variables.sh b/infrastructure/environments/prod/variables.sh
@@ -7,7 +7,6 @@ HUB=prod
 ENABLE_SOFT_DELETE=true
 ADO_MANAGEMENT_POOL=private-pool-prod-uks
 CLOUD_API_HOSTNAME=manage-breast-screening.nhs.uk
-SCREENING_ENTRA_GROUP_ID="3b2b22b0-ac8e-4904-a94b-9010ff08698a"
 # ring1 = first real sites (one per PACS vendor)
 # To onboard more rings: set GATEWAY_RINGS="ring0 ring1 ring2 ..." in this file
 GATEWAY_RINGS="ring1"
diff --git a/infrastructure/environments/prod/variables.tfvars b/infrastructure/environments/prod/variables.tfvars
@@ -1,2 +1,2 @@
 # All values use defaults: enable_gateway_test_vm = false, enable_arc_servers = true
-SCREENING_ENTRA_GROUP_ID = "3b2b22b0-ac8e-4904-a94b-9010ff08698a"
+screening_entra_group_id = "3b2b22b0-ac8e-4904-a94b-9010ff08698a"

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`# All values use defaults: enable_gateway_test_vm = false, enable_arc_servers = true`
`2`		`-SCREENING_ENTRA_GROUP_ID = "3b2b22b0-ac8e-4904-a94b-9010ff08698a"`
	`2`	`+screening_entra_group_id = "3b2b22b0-ac8e-4904-a94b-9010ff08698a"`