Ensure AE title is less than 16 chars in review - #130
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Arc deployment script so the MWL/PACS AE title suffix derived from ENVIRONMENT stays within the DICOM 16-character AE Title limit (notably for the review environment).
Changes:
- Replace the prior
PREPRODspecial-casing with a generic 3-character truncation ofAPI_ENVIRONMENTto keep AE titles under 16 chars.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
steventux
force-pushed
the
fix-review-ae-title
branch
from
June 9, 2026 16:13
e2984ef to
3e40a03
Compare
steventux
force-pushed
the
fix-review-ae-title
branch
from
June 9, 2026 16:21
3e40a03 to
2824054
Compare
steventux
force-pushed
the
fix-review-ae-title
branch
from
June 10, 2026 07:41
2824054 to
99fdad6
Compare
steventux
force-pushed
the
fix-review-ae-title
branch
from
June 10, 2026 08:05
99fdad6 to
87968f6
Compare
Truncates REVIEW and PREPROD to REV and PRE eg. RUBIE_PACS_PRE
steventux
force-pushed
the
fix-review-ae-title
branch
from
June 10, 2026 08:13
87968f6 to
29a7e60
Compare
MatMoore
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PACS AE title becomes
RUBIE_PACS_REVIEWwhich is > 16 chars and prevents the service from working.Truncate the env portion of the AE title to 3 chars if it's over 4 chars.
RUBIE_PACS_REVIEW->RUBIE_PACS_REVRUBIE_PACS_PREPROD->RUBIE_PACS_PREwhile retaining
RUBIE_PACS_DEVandRUBIE_PACS_PRODJira link
Review notes
Review checklist