Dtoss remove per hc sas listen keys ahl - #175
Closed
mrlockstar wants to merge 4 commits into
Closed
Conversation
…eview environment
…nt, keeps the .env block cleaner and avoids inserting optional auth vars into the main env list, preserves alphabetical / logical ordering of the env vars in the generated content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restrict Azure Relay SAS keys to review environment only
Remove unnecessary SAS key exposure from dev, preprod, and prod relay Hybrid Connections.
arc-infra/relay.tf currently provisions a listen-only SAS rule in all environments as a break-glass fallback.
All deployed environments now authenticate to Azure Relay using Managed Identity, so retaining SAS keys increases attack surface.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-13123
Review notes
Review checklist