Make test_existing_sop_instance_uid better match implementation - #42
Merged
Merged
Conversation
steventux
reviewed
Mar 9, 2026
carlosmartinez
force-pushed
the
fix/cstore-existing-sop-improve-test
branch
from
March 9, 2026 17:09
4e6736d to
137070f
Compare
josielsouzanordcloud
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The requirement is:
Actually the code already does this (thanks @steventux).
This PR just slightly improves the existing test (which would pass even if the
InstanceExistsErrorweren't raised in the implementation).Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12388