Skip to content

Make test_existing_sop_instance_uid better match implementation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmartinez merged 1 commit into from
Mar 9, 2026
Merged

Make test_existing_sop_instance_uid better match implementation #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/services/dicom/test_c_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ def test_no_patient_id_fails(self, mock_storage, mock_event):
assert subject.call(mock_event) == FAILURE

def test_existing_sop_instance_uid(self, mock_storage, mock_event):
mock_storage.instance_exists.return_value = True
mock_storage.store_instance.side_effect = pydicom.uid.generate_uid()
subject = CStore(mock_storage)

assert subject.call(mock_event) == SUCCESS
mock_storage.store_instance.assert_called_once()

def test_valid_event_is_stored(self, mock_storage, mock_event):
mock_storage.instance_exists.return_value = False
Expand Down
Loading