C-STORE validation failure notifies Manage API - #43
Merged
Conversation
Via ValidationFailureNotifier#notify
carlosmartinez
force-pushed
the
feat/notify-dicom-failure
branch
from
March 11, 2026 11:38
53d7b06 to
9513cc7
Compare
steventux
reviewed
Mar 11, 2026
steventux
reviewed
Mar 11, 2026
Contributor
Author
|
Thank for useful comments @steventux, all addressed I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're already logging DicomValidationError on C-STORE. This PR adds to this by POSTing to a Manage endpoint such that the clinic user can be notified.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12391