Skip to content

[DTOSS-12521] - Skip deploy stage on PRs without deploy label - #57

Merged
josielsouzanordcloud merged 1 commit into
mainfrom
DTOSS-12521-skip-deploy-for-dependabot-prs
Mar 23, 2026
Merged

[DTOSS-12521] - Skip deploy stage on PRs without deploy label#57
josielsouzanordcloud merged 1 commit into
mainfrom
DTOSS-12521-skip-deploy-for-dependabot-prs

Conversation

@josielsouzanordcloud

Copy link
Copy Markdown
Contributor

Description

This PR adds a condition to skip the deploy stage for pull requests (PRs) that do not have the 'deploy' label. Dependabot PRs do not have access to repository secrets by design, which causes the deploy stage to fail during Azure login. By gating the deploy stage behind the 'deploy' label, this aligns with the existing approach used in other pipelines.

Type of change

Tick all that apply with [x], leave others as [ ]:

  • Bug fix
  • New feature
  • Breaking change
  • Infrastructure change
  • Pipeline / CI
  • Documentation update
  • Refactor

Jira link

DTOSS-12521

Review notes

  • The deploy stage in the .github/workflows/cicd-1-pull-request.yaml file now checks if the PR has the 'deploy' label before executing.
  • This change ensures that Dependabot PRs, which do not have access to repository secrets, do not attempt the deploy stage.

Impact

  • Deployment: The deploy stage will only run for PRs with the 'deploy' label.
  • Services: No impact on running services.
  • Security: Enhances security by preventing unauthorized access to deployment secrets.
  • Cost: No direct cost impact.

  Dependabot PRs do not have access to repository secrets by design,
  causing the deploy stage to fail on Azure login. Gate deploy-stage
  behind the deploy label, consistent with deploy-app-stage and the
  approach used in dtos-manage-breast-screening.

@steventux steventux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@josielsouzanordcloud
josielsouzanordcloud merged commit 42abf86 into main Mar 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants