Remove db connection mocks from storage service unit test - #58
Merged
Conversation
|
|
||
| assert len(results) == 1 | ||
|
|
||
| def test_find_worklist_items_patient_name_wildcard_conversion(self, mwl_storage, result): |
Contributor
There was a problem hiding this comment.
are we happy that the deleted parameterised test for wildcard matching is adequately covered by this?
Contributor
Author
There was a problem hiding this comment.
Oh no, no we are not, bad AI
steventux
force-pushed
the
fix/remove-db-mocking-from-storage-test
branch
2 times, most recently
from
March 25, 2026 11:33
c33a0f1 to
5762c19
Compare
carlosmartinez
approved these changes
Mar 25, 2026
steventux
force-pushed
the
fix/remove-db-mocking-from-storage-test
branch
from
March 25, 2026 16:03
5762c19 to
627e53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We started by mocking database connections in the storage service unit tests, this isn't reliable and given we use SQLite3 we can teardown cheaply.
Refactor test_storage.py to use a test SQLite3 instance.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12484
Review notes
Review checklist