On successful C-STORE, transition worklist item to IN_PROGRESS. - #71
Merged
Conversation
steventux
reviewed
Mar 30, 2026
steventux
reviewed
Mar 30, 2026
steventux
reviewed
Mar 30, 2026
steventux
approved these changes
Mar 30, 2026
steventux
left a comment
steventux
left a comment
Contributor
There was a problem hiding this comment.
We could use the MWLStatus enum instead of strings.
I think there's an opportunity to make update_status a bit smarter but not a blocker.
Contributor
|
@carlosmartinez having thought about it properly and when awake I realised my idea was not ideal. We need a single state transition not a set of them. Otherwise the second .dcm file for a given accession number would move the worklist item to the next state, my mistake for overcomplicating while misunderstanding the issue, |
In the absence (for now) of MPPS N-CREATE and N-SET messages, manage appointment state with worklist item status. Status is set to "IN PROGRESS" on a successful C-STORE command for the corresponding accession_number.
Such that it only performs valid status transitions
carlosmartinez
force-pushed
the
feat/mark-worklist-item-in-progress
branch
from
March 31, 2026 10:33
9f7fd73 to
070aaaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the absence (for now) of MPPS N-CREATE and N-SET messages, manage appointment state with worklist item status. Status is set to "IN PROGRESS" on a successful C-STORE command for the corresponding accession_number.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12565