Skip to content

Commit bf29262

Browse files
committed
Make sure ensure-run-success job always runs
Previously if this job was skipped, the PR could still be merged.
1 parent 0b9c6c6 commit bf29262

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,10 @@ jobs:
6161
name: Ensure end-to-end tests ran successfully
6262
runs-on: ubuntu-latest
6363
needs: [run-against-staging, run-against-container]
64-
if: |
65-
always() && (
66-
needs.run-against-staging.result == 'success' ||
67-
needs.run-against-container.result == 'success'
68-
)
64+
if: always()
6965
steps:
70-
- name: Output result
71-
run: echo "End-to-end tests ran successfully"
66+
- name: Fail if neither end-to-end job succeeded
67+
if: |
68+
needs.run-against-staging.result != 'success' &&
69+
needs.run-against-container.result != 'success'
70+
run: exit 1

0 commit comments

Comments
 (0)