Allow editing of phase values

Add a "Change" link from the school edit screen for the Phase value. Users can choose from one of the four default phase groups.

Author: murugapl

app/components/app_location_search_form_component.rb

@@ -8,7 +8,7 @@ def initialize(form, url:)
 
   private
 
-  PHASES = %w[nursery primary secondary other].freeze
+  PHASES = Location::PHASES
 
   attr_reader :form, :url
 

app/components/app_school_summary_component.rb

@@ -62,14 +62,26 @@ def name_row
   end
 
   def phase_row
-    {
+    row = {
       key: {
         text: "Phase"
       },
       value: {
         text: schoolable.human_enum_name(:phase)
       }
     }
+
+    if change_links[:phase]
+      row[:actions] = [
+        {
+          text: change_links[:phase][:text] || "Change",
+          href: change_links[:phase][:link],
+          visually_hidden_text: "phase"
+        }
+      ]
+    end
+
+    row
   end
 
   def programmes_row

app/controllers/draft_schools_controller.rb

@@ -12,6 +12,7 @@ class DraftSchoolsController < ApplicationController
   before_action :set_name, if: -> { current_step == :confirm_urn }
   before_action :set_address,
                 if: -> { %i[details confirm_urn].include?(current_step) }
+  before_action :set_phases, if: -> { current_step == :phase }
   before_action :set_year_groups, if: -> { current_step == :year_groups }
   before_action :set_back_link_path
 
@@ -91,6 +92,10 @@ def set_name
     @draft_school.name ||= @draft_school.source_location&.name
   end
 
+  def set_phases
+    @phases = Location::PHASES
+  end
+
   def set_year_groups
     @year_groups =
       Location::YearGroup::DEFAULT_VALUE_RANGE.map do |n|
@@ -231,6 +236,7 @@ def update_params
         address_town
         address_postcode
       ],
+      phase: [:phase],
       year_groups: [{ year_groups: [] }],
       confirm: []
     }.fetch(current_step)

app/models/draft_school.rb

@@ -14,6 +14,7 @@ class DraftSchool
   attribute :address_town, :string
   attribute :address_postcode, :string
   attribute :selected_year_groups, default: []
+  attribute :phase, :string
   attribute :context, :string
 
   attr_reader :current_team
@@ -51,6 +52,7 @@ def wizard_steps
       (:details if add_site_context? || editing?),
       (:urn if add_school_context?),
       (:confirm_urn if add_school_context?),
+      :phase,
       :year_groups,
       :confirm
     ].compact
@@ -93,6 +95,10 @@ def add_site_context?
     validates :address_postcode, postcode: true
   end
 
+  on_wizard_step :phase, exact: true do
+    validates :phase, presence: true, inclusion: { in: Location::PHASES }
+  end
+
   on_wizard_step :year_groups, exact: true do
     validates :selected_year_groups, presence: true
     validate :cannot_remove_year_groups
@@ -141,7 +147,7 @@ def readable_attribute_names
   end
 
   def writable_attribute_names
-    %w[name address_line_1 address_line_2 address_town address_postcode]
+    %w[name address_line_1 address_line_2 address_town address_postcode phase]
   end
 
   def resolved_urn
@@ -167,6 +173,10 @@ def next_site_letter
     existing_sites.max_by { [it.length, it] }.next
   end
 
+  def phase
+    super.presence || source_location&.phase
+  end
+
   def existing_year_groups
     source_location&.year_groups.presence ||
       source_location&.gias_year_groups || []
@@ -190,7 +200,7 @@ def programmes
   end
 
   def human_enum_name(attr)
-    source_location&.human_enum_name(attr)
+    Location.human_enum_name(attr, public_send(attr))
   end
 
   def schools_with_urn

app/views/draft_schools/confirm.html.erb

@@ -24,10 +24,14 @@
            {
              name: { link: wizard_path(:details) },
              address: { link: wizard_path(:details) },
+             phase: { link: wizard_path(:phase) },
              year_groups: { link: wizard_path("year-groups") },
            }
          else
-           { year_groups: { link: wizard_path("year-groups") } }
+           {
+             phase: { link: wizard_path(:phase) },
+             year_groups: { link: wizard_path("year-groups") },
+           }
          end
        elsif @draft_school.add_site_context?
          { urn: { link: wizard_path(:school), text: "Change parent school" } }

app/views/draft_schools/phase.html.erb

@@ -0,0 +1,15 @@
+<% content_for :before_main do %>
+  <%= govuk_back_link(href: @back_link_path) %>
+<% end %>
+
+<% legend = "Phase" %>
+<% content_for :page_title, legend %>
+
+<%= form_with model: @draft_school, url: wizard_path, method: :put do |f| %>
+  <%= f.mavis_error_summary %>
+  <%= f.govuk_collection_radio_buttons :phase, @phases, :itself, :humanize,
+                                       legend: { text: legend, size: "l", tag: "h1" },
+                                       caption: { text: @draft_school.name || @draft_school.source_location&.name, size: "l" } %>
+
+  <%= f.govuk_submit "Continue" %>
+<% end %>

config/locales/en.yml

@@ -94,6 +94,9 @@ en:
               inclusion: Choose if this is the correct school
             name:
               blank: Enter a name
+            phase:
+              blank: Choose a phase
+              inclusion: Choose a phase
             parent_urn_and_site:
               blank: Choose a school
             selected_year_groups:
@@ -778,6 +781,8 @@ en:
               inclusion: Choose a GIAS phase
             name:
               blank: Enter a name
+            phase:
+              inclusion: Choose a phase
             ods_code:
               blank: Enter an ODS code
               exclusion: This ODS code is not allowed

config/locales/wicked.en.yml

@@ -38,6 +38,7 @@ en:
     outcome: outcome
     parent: parent
     parent_details: parent-details
+    phase: phase
     programmes: programmes
     programmes_check: programmes-check
     questions: questions

spec/components/app_school_summary_component_spec.rb

@@ -53,6 +53,9 @@
           link: "/address",
           text: "Change address"
         },
+        phase: {
+          link: "/phase"
+        },
         year_groups: {
           link: "/year-groups"
         }
@@ -62,6 +65,7 @@
 
     it { should have_link("Change name", href: "/name") }
     it { should have_link("Change address", href: "/address") }
+    it { should have_link("Change phase", href: "/phase") }
     it { should have_link("Change year groups", href: "/year-groups") }
   end
 
@@ -142,6 +146,12 @@
       expect(rendered).to have_content("Secondary")
     end
 
+    it "shows the selected phase when overridden in the draft" do
+      draft_school.phase = "primary"
+      expect(rendered).to have_content("Primary")
+      expect(rendered).not_to have_content("Secondary")
+    end
+
     it "shows programmes from the underlying location" do
       expect(rendered).to have_content("Programmes")
       expect(rendered).to have_content("HPV")

spec/features/manage_teams_spec.rb

@@ -50,6 +50,10 @@
 
     when_i_confirm_the_school
     and_i_continue
+    then_i_see_the_phase_screen
+
+    when_i_select_a_phase
+    and_i_continue
     then_i_see_the_year_groups_screen
     and_year_groups_are_pre_selected
 
@@ -80,6 +84,10 @@
 
     when_i_fill_in_the_school_site_details
     and_i_continue
+    then_i_see_the_phase_screen
+
+    when_i_select_a_phase
+    and_i_continue
     then_i_see_the_year_groups_screen
     and_year_groups_are_pre_selected
 
@@ -136,6 +144,25 @@
     and_the_site_details_are_updated
   end
 
+  scenario "Editing a school phase" do
+    given_my_team_exists
+
+    when_i_click_on_team_settings
+    when_i_click_on_schools
+
+    when_i_click_on_edit_a_school
+    then_i_see_the_school_summary_with_phase_and_year_groups_links
+
+    when_i_click_on_change_phase
+    and_i_select_a_new_phase
+    and_i_continue
+    then_i_see_the_phase_is_updated
+
+    when_i_click_save_changes
+    then_i_see_the_team_schools
+    and_the_school_phase_is_updated
+  end
+
   scenario "Editing a school" do
     given_my_team_exists
 
@@ -144,7 +171,7 @@
     then_i_see_the_team_schools
 
     when_i_click_on_edit_a_school
-    then_i_see_the_school_summary_with_only_year_groups_link
+    then_i_see_the_school_summary_with_phase_and_year_groups_links
 
     when_i_click_on_change_year_groups
     when_i_try_to_remove_a_year_group
@@ -241,11 +268,13 @@ def then_i_see_the_school_summary_with_edit_links
     expect(page).to have_content("Site B")
     expect(page).to have_link("Change", text: /name/i)
     expect(page).to have_link("Change", text: /address/i)
+    expect(page).to have_link("Change", text: /phase/i)
     expect(page).to have_link("Change", text: /year groups/i)
   end
 
-  def then_i_see_the_school_summary_with_only_year_groups_link
+  def then_i_see_the_school_summary_with_phase_and_year_groups_links
     expect(page).to have_content(@school.name)
+    expect(page).to have_link("Change", text: /phase/i)
     expect(page).to have_link("Change", text: /year groups/i)
     expect(page).not_to have_link("Change", text: /name/i)
     expect(page).not_to have_link("Change", text: /address/i)
@@ -529,4 +558,31 @@ def and_the_school_has_the_correct_year_groups
     @available_school.reload
     expect(@available_school.location_year_groups.pluck(:value)).to include(12)
   end
+
+  def then_i_see_the_phase_screen
+    expect(page).to have_content("Phase")
+    expect(page).to have_field("Primary", type: :radio)
+    expect(page).to have_field("Secondary", type: :radio)
+  end
+
+  def when_i_select_a_phase
+    choose "Secondary"
+  end
+
+  def when_i_click_on_change_phase
+    click_on "Change phase"
+  end
+
+  def and_i_select_a_new_phase
+    choose "Primary"
+  end
+
+  def then_i_see_the_phase_is_updated
+    expect(page).to have_content("Primary")
+  end
+
+  def and_the_school_phase_is_updated
+    @school.reload
+    expect(@school.phase).to eq("primary")
+  end
 end