Skip to content

Rename processed? to processed_at?#6637

Merged
misaka merged 1 commit intonextfrom
rename-processed-to-processed-at
Apr 28, 2026
Merged

Rename processed? to processed_at?#6637
misaka merged 1 commit intonextfrom
rename-processed-to-processed-at

Conversation

@misaka
Copy link
Copy Markdown
Collaborator

@misaka misaka commented Apr 20, 2026

We already have a status in CSVImportable called processed so it's helper method processed? was being masked by this method. We also don't have to define a processed_at? as Rails has automatically generated one for use.

MAV-6746

@misaka misaka requested a review from a team as a code owner April 20, 2026 10:37
@misaka misaka added the refactor Improving maintainability label Apr 20, 2026
@misaka misaka added this to the v8.2.0 milestone Apr 20, 2026
@misaka misaka modified the milestones: v8.2.0, v8.3.0 Apr 22, 2026
@misaka misaka force-pushed the rename-processed-to-processed-at branch 2 times, most recently from 30dc517 to 6be908d Compare April 24, 2026 14:36
@misaka misaka force-pushed the rename-processed-to-processed-at branch from 6be908d to 8c00ef7 Compare April 27, 2026 14:41
@misaka misaka merged commit a9b57dc into next Apr 28, 2026
15 checks passed
@misaka misaka deleted the rename-processed-to-processed-at branch April 28, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improving maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants