Skip to content

Commit a276e1d

Browse files
CCM-18477: Fix for pact tests (#592)
* potential pact fix * babel file * eslint issue * lockfile * fix: remove stale pact-core@17.1.0 lockfile entry in tests workspace The lockfile had an inconsistency: tests/node_modules/@pact-foundation/pact-core was locked at 17.1.0 (a stale entry from before pact was upgraded), while every package in the tree that depends on pact-core now requires ^19.2.0. npm install would reinstall 17.1.0 faithfully from the lockfile, which caused 'npm rebuild @pact-foundation/pact-core' to target the wrong version. Also flagged as invalid by npm ls. Removed the stale tests/node_modules/@pact-foundation/pact-core entries (main + all 7 platform binaries) from the lockfile. After npm install, the tests workspace now deduplicates to the root's node_modules/@pact-foundation/pact-core@19.2.0, which is the single correct version used by all packages in the tree.
1 parent 65d4395 commit a276e1d

6 files changed

Lines changed: 4497 additions & 2907 deletions

File tree

eslint.config.mjs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export default defineConfig([
5656
'**/node_modules',
5757
'**/dist',
5858
'**/test-results',
59+
'**/target/**',
5960
'**/playwright-report*',
6061
'eslint.config.mjs',
6162
// newly ignored generated/build artifacts
@@ -91,6 +92,22 @@ export default defineConfig([
9192
},
9293
},
9394
{ files: ['**/*.json'], extends: [tseslint.configs.disableTypeChecked] },
95+
{
96+
files: ['**/*.js', '**/*.cjs', '**/*.mjs'],
97+
extends: [tseslint.configs.disableTypeChecked],
98+
},
99+
{
100+
files: ['**/*.cjs'],
101+
languageOptions: {
102+
globals: {
103+
module: 'readonly',
104+
require: 'readonly',
105+
exports: 'readonly',
106+
__dirname: 'readonly',
107+
__filename: 'readonly',
108+
},
109+
},
110+
},
94111

95112
{
96113
settings: {

0 commit comments

Comments
 (0)