CCM-13382: Add Automation Tests (#578)

Namitha-Prabhu · web-flow · commit bfea977585ff · 2026-06-04T15:48:09.000+01:00
* tests

* data

* tests

* data

* tests

* lint

* fix

* lint fix

* config

* config changes

* config changes

* config fix

* tests

* fix

* lint fix

* Update event-fixtures.ts

remove unused ref

* config fix

* config fix

* Update allocation-helper.ts

* add test to config

* add missing ref

* fix flaky tests

* fix flaky tests

* remove duplicate tests

* fix comments
diff --git a/config/suppliers/letter-variant/client1-campaign2.json b/config/suppliers/letter-variant/client1-campaign2.json
@@ -32,7 +32,7 @@
     "client1-campaign2"
   ],
   "priority": 1,
-  "status": "INT",
+  "status": "PROD",
   "type": "STANDARD",
-  "volumeGroupId": "volumeGroup-test3"
+  "volumeGroupId": "volumeGroup-test4"
 }
diff --git a/config/suppliers/letter-variant/notify-first-test.json b/config/suppliers/letter-variant/notify-first-test.json
@@ -0,0 +1,30 @@
+{
+  "constraints": {
+    "blackCoveragePercentage": {
+      "operator": "LESS_THAN",
+      "value": 20
+    },
+    "deliveryDays": {
+      "operator": "LESS_THAN",
+      "value": 2
+    },
+    "sheets": {
+      "operator": "LESS_THAN",
+      "value": 5
+    },
+    "sides": {
+      "operator": "LESS_THAN",
+      "value": 10
+    }
+  },
+  "description": "Black printing, first class postage tariff",
+  "id": "notify-first-test",
+  "name": "First class letter",
+  "packSpecificationIds": [
+    "notify-first-test"
+  ],
+  "priority": 10,
+  "status": "PROD",
+  "type": "STANDARD",
+  "volumeGroupId": "volumeGroup-test5"
+}
diff --git a/config/suppliers/letter-variant/notify-standard-test1.json b/config/suppliers/letter-variant/notify-standard-test1.json
@@ -21,7 +21,8 @@
   "id": "notify-standard-test1",
   "name": "Dev Happy Path",
   "packSpecificationIds": [
-    "notify-c5"
+    "notify-c5",
+    "notify-c4"
   ],
   "priority": 50,
   "status": "PROD",
diff --git a/config/suppliers/pack-specification/client1-campaign2.json b/config/suppliers/pack-specification/client1-campaign2.json
@@ -49,7 +49,7 @@
     "maxWeightGrams": 100,
     "size": "STANDARD"
   },
-  "status": "INT",
+  "status": "PROD",
   "updatedAt": "2026-04-14T00:00:00.000Z",
   "version": 1
 }
diff --git a/config/suppliers/pack-specification/notify-first-test.json b/config/suppliers/pack-specification/notify-first-test.json
@@ -0,0 +1,48 @@
+{
+  "assembly": {
+    "duplex": true,
+    "envelopeId": "first-c5",
+    "paper": {
+      "colour": "WHITE",
+      "id": "paper-std-white-80",
+      "name": "Standard White 80gsm",
+      "recycled": true,
+      "size": "A4",
+      "weightGSM": 80
+    },
+    "printColour": "BLACK"
+  },
+  "billingId": "notify-first-test",
+  "constraints": {
+    "blackCoveragePercentage": {
+      "operator": "LESS_THAN",
+      "value": 20
+    },
+    "deliveryDays": {
+      "operator": "LESS_THAN",
+      "value": 2
+    },
+    "sheets": {
+      "operator": "LESS_THAN",
+      "value": 5
+    },
+    "sides": {
+      "operator": "LESS_THAN",
+      "value": 10
+    }
+  },
+  "createdAt": "2026-01-12T00:00:00.000Z",
+  "description": "First class postage tariff",
+  "id": "notify-first-test",
+  "name": "First class",
+  "postage": {
+    "deliveryDays": 2,
+    "id": "first-class",
+    "maxThicknessMm": 5,
+    "maxWeightGrams": 100,
+    "size": "STANDARD"
+  },
+  "status": "PROD",
+  "updatedAt": "2026-01-12T00:00:00.000Z",
+  "version": 1
+}
diff --git a/config/suppliers/supplier-allocation/supplier1-volumeGroup-test3.json b/config/suppliers/supplier-allocation/supplier1-volumeGroup-test3.json
@@ -1,5 +1,5 @@
 {
-  "allocationPercentage": 100,
+  "allocationPercentage": 50,
   "id": "supplier1-volumeGroup-test3",
   "status": "PROD",
   "supplier": "supplier1",
diff --git a/config/suppliers/supplier-allocation/supplier2-volumeGroup-test3.json b/config/suppliers/supplier-allocation/supplier2-volumeGroup-test3.json
@@ -0,0 +1,7 @@
+{
+  "allocationPercentage": 50,
+  "id": "supplier2-volumeGroup-test3",
+  "status": "PROD",
+  "supplier": "supplier2",
+  "volumeGroup": "volumeGroup-test3"
+}
diff --git a/config/suppliers/supplier-allocation/supplier3-volumeGroup-test4.json b/config/suppliers/supplier-allocation/supplier3-volumeGroup-test4.json
@@ -0,0 +1,7 @@
+{
+  "allocationPercentage": 50,
+  "id": "supplier3-volumeGroup-test4",
+  "status": "PROD",
+  "supplier": "supplier3",
+  "volumeGroup": "volumeGroup-test4"
+}
diff --git a/config/suppliers/supplier-allocation/supplier4-volumeGroup-test4.json b/config/suppliers/supplier-allocation/supplier4-volumeGroup-test4.json
@@ -0,0 +1,7 @@
+{
+  "allocationPercentage": 50,
+  "id": "supplier4-volumeGroup-test4",
+  "status": "PROD",
+  "supplier": "supplier4",
+  "volumeGroup": "volumeGroup-test4"
+}
diff --git a/config/suppliers/supplier-allocation/supplier5-volumeGroup-test5.json b/config/suppliers/supplier-allocation/supplier5-volumeGroup-test5.json
@@ -0,0 +1,7 @@
+{
+  "allocationPercentage": 100,
+  "id": "supplier5-volumeGroup-test5",
+  "status": "PROD",
+  "supplier": "supplier5",
+  "volumeGroup": "volumeGroup-test5"
+}
diff --git a/config/suppliers/supplier-pack/supplier1-client1-campaign8.json b/config/suppliers/supplier-pack/supplier1-client1-campaign8.json
@@ -3,5 +3,5 @@
   "id": "supplier1-client1-campaign8",
   "packSpecificationId": "client1-campaign8",
   "status": "PROD",
-  "supplierId": "supplier1"
+  "supplierId": ""
 }
diff --git a/config/suppliers/supplier-pack/supplier2-client1-campaign1.json b/config/suppliers/supplier-pack/supplier2-client1-campaign1.json
@@ -0,0 +1,7 @@
+{
+  "approval": "APPROVED",
+  "id": "supplier2-client1-campaign1",
+  "packSpecificationId": "client1-campaign1",
+  "status": "PROD",
+  "supplierId": "supplier2"
+}
diff --git a/config/suppliers/supplier-pack/supplier3-client1-campaign2.json b/config/suppliers/supplier-pack/supplier3-client1-campaign2.json
@@ -0,0 +1,7 @@
+{
+  "approval": "APPROVED",
+  "id": "supplier3-client1-campaign2",
+  "packSpecificationId": "client1-campaign2",
+  "status": "PROD",
+  "supplierId": "supplier3"
+}
diff --git a/config/suppliers/supplier-pack/supplier4-client1-campaign2.json b/config/suppliers/supplier-pack/supplier4-client1-campaign2.json
@@ -0,0 +1,7 @@
+{
+  "approval": "APPROVED",
+  "id": "supplier4-client1-campaign2",
+  "packSpecificationId": "client1-campaign2",
+  "status": "PROD",
+  "supplierId": "supplier4"
+}
diff --git a/config/suppliers/supplier-pack/supplier5-notify-first-test.json b/config/suppliers/supplier-pack/supplier5-notify-first-test.json
@@ -0,0 +1,7 @@
+{
+  "approval": "APPROVED",
+  "id": "supplier5-notify-first-test",
+  "packSpecificationId": "notify-first-test",
+  "status": "PROD",
+  "supplierId": "supplier5"
+}
diff --git a/config/suppliers/supplier/supplier3.json b/config/suppliers/supplier/supplier3.json
@@ -0,0 +1,7 @@
+{
+  "channelType": "LETTER",
+  "dailyCapacity": 500000,
+  "id": "supplier3",
+  "name": "Supplier3",
+  "status": "PROD"
+}
diff --git a/config/suppliers/supplier/supplier4.json b/config/suppliers/supplier/supplier4.json
@@ -0,0 +1,7 @@
+{
+  "channelType": "LETTER",
+  "dailyCapacity": 500000,
+  "id": "supplier4",
+  "name": "Supplier4",
+  "status": "PROD"
+}
diff --git a/config/suppliers/supplier/supplier5.json b/config/suppliers/supplier/supplier5.json
@@ -0,0 +1,7 @@
+{
+  "channelType": "LETTER",
+  "dailyCapacity": 500000,
+  "id": "supplier5",
+  "name": "Supplier5",
+  "status": "PROD"
+}
diff --git a/config/suppliers/volume-group/volumeGroup-test4.json b/config/suppliers/volume-group/volumeGroup-test4.json
@@ -0,0 +1,7 @@
+{
+  "description": "Dev Test Volume Group 4",
+  "id": "volumeGroup-test4",
+  "name": "Dev Test Volume Group 4",
+  "startDate": "2026-01-01",
+  "status": "PROD"
+}
diff --git a/config/suppliers/volume-group/volumeGroup-test5.json b/config/suppliers/volume-group/volumeGroup-test5.json
@@ -0,0 +1,7 @@
+{
+  "description": "Dev Test Volume Group 5",
+  "id": "volumeGroup-test5",
+  "name": "Dev Test Volume Group 5",
+  "startDate": "2026-01-01",
+  "status": "PROD"
+}
diff --git a/internal/datastore/src/supplier-config-repository.ts b/internal/datastore/src/supplier-config-repository.ts
@@ -129,7 +129,6 @@ export class SupplierConfigRepository {
         },
       }),
     );
-
     return $SupplierPack.array().parse(result.Items);
   }
 
diff --git a/tests/component-tests/allocation-tests/allocation-target-percentage.spec.ts b/tests/component-tests/allocation-tests/allocation-target-percentage.spec.ts
@@ -0,0 +1,84 @@
+import { randomUUID } from "node:crypto";
+import test, { expect } from "playwright/test";
+import {
+  getAllocationLogForDomainId,
+  getLetterVariantConfigFromDb,
+  getSupplierFromSupplierPack,
+  getVariantsForAllocation,
+  updateSupplierAllocation,
+} from "tests/helpers/allocation-helper";
+import { createPreparedV1Event } from "tests/helpers/event-fixtures";
+import { getLettersFromSupplierTable } from "tests/helpers/generate-fetch-test-data";
+import { sendSnsEvent } from "tests/helpers/send-sns-event";
+
+test.describe("Allocation Target Percentage Tests", () => {
+  test.setTimeout(180_000); // 3 minutes for long running polling
+  test("Verify that supplier with zero target percentage is handled correctly", async () => {
+    const letterVariant = getVariantsForAllocation(8);
+    const domainId = `Zero-Percentage-${randomUUID()}`;
+
+    const letterVariantConfig =
+      await getLetterVariantConfigFromDb(letterVariant);
+    const volGroupId = letterVariantConfig.volumeGroupId;
+
+    // update target percentage
+    await updateSupplierAllocation("supplier1", volGroupId, 0);
+    const preparedEvent = createPreparedV1Event({
+      domainId,
+      letterVariantId: letterVariant,
+    });
+
+    const response = await sendSnsEvent(preparedEvent);
+    expect(response.MessageId).toBeTruthy();
+
+    const allocationLog = await getAllocationLogForDomainId(domainId);
+    const lettersInDb = await getLettersFromSupplierTable(
+      "unknown",
+      domainId,
+      "REJECTED",
+    );
+
+    expect(lettersInDb.status).toBe("REJECTED");
+    expect(lettersInDb.supplierId).toBe(
+      allocationLog.msg?.allocationDetails?.supplierSpec?.supplierId,
+    );
+    expect(lettersInDb.reasonCode).toBe("NO_SUPPLIERS_AVAILABLE");
+    expect(lettersInDb.reasonText).toBe(
+      `No valid supplier allocations found for suppliers with valid pack`,
+    );
+  });
+
+  test("Verify that supplier with less than 100 target percentage is handled correctly", async () => {
+    const letterVariant = getVariantsForAllocation(5);
+    const domainId = `Less-Than-100-Percentage-${randomUUID()}`;
+
+    const letterVariantConfig =
+      await getLetterVariantConfigFromDb(letterVariant);
+    const volGroupId = letterVariantConfig.volumeGroupId;
+    const [packSpecificationId] = letterVariantConfig.packSpecificationIds;
+
+    // update target percentage
+    const [supplier] = await getSupplierFromSupplierPack(packSpecificationId);
+
+    await updateSupplierAllocation(supplier, volGroupId, 50);
+    const preparedEvent = createPreparedV1Event({
+      domainId,
+      letterVariantId: letterVariant,
+    });
+
+    const response = await sendSnsEvent(preparedEvent);
+    expect(response.MessageId).toBeTruthy();
+
+    const allocationLog = await getAllocationLogForDomainId(domainId);
+    const lettersInDb = await getLettersFromSupplierTable(
+      allocationLog.msg?.allocationDetails?.supplierSpec?.supplierId!,
+      domainId,
+      "PENDING",
+    );
+
+    expect(lettersInDb.supplierId).toBe(
+      allocationLog.msg?.allocationDetails?.supplierSpec?.supplierId,
+    );
+    await updateSupplierAllocation(supplier, volGroupId, 100); // reset target percentage to avoid impact on other tests
+  });
+});
diff --git a/tests/component-tests/allocation-tests/letter-allocation-capacity.spec.ts b/tests/component-tests/allocation-tests/letter-allocation-capacity.spec.ts
diff --git a/tests/component-tests/allocation-tests/letter-allocation-rejected.spec.ts b/tests/component-tests/allocation-tests/letter-allocation-rejected.spec.ts
diff --git a/tests/component-tests/allocation-tests/letter-allocation-weighting.spec.ts b/tests/component-tests/allocation-tests/letter-allocation-weighting.spec.ts
diff --git a/tests/component-tests/events-tests/event-subscription.spec.ts b/tests/component-tests/events-tests/event-subscription.spec.ts
diff --git a/tests/config/main.config.ts b/tests/config/main.config.ts
diff --git a/tests/helpers/allocation-factor-helper.ts b/tests/helpers/allocation-factor-helper.ts
diff --git a/tests/helpers/allocation-helper.ts b/tests/helpers/allocation-helper.ts
diff --git a/tests/helpers/aws-cloudwatch-helper.ts b/tests/helpers/aws-cloudwatch-helper.ts
diff --git a/tests/helpers/event-fixtures.ts b/tests/helpers/event-fixtures.ts
diff --git a/tests/helpers/generate-fetch-test-data.ts b/tests/helpers/generate-fetch-test-data.ts

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@`
`49`	`49`	`"maxWeightGrams": 100,`
`50`	`50`	`"size": "STANDARD"`
`51`	`51`	`},`
`52`		`- "status": "INT",`
	`52`	`+ "status": "PROD",`
`53`	`53`	`"updatedAt": "2026-04-14T00:00:00.000Z",`
`54`	`54`	`"version": 1`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "allocationPercentage": 100,`
	`2`	`+ "allocationPercentage": 50,`
`3`	`3`	`"id": "supplier1-volumeGroup-test3",`
`4`	`4`	`"status": "PROD",`
`5`	`5`	`"supplier": "supplier1",`