fix comments

Author: Namitha-Prabhu

tests/component-tests/allocation-tests/letter-allocation-rejected.spec.ts

@@ -6,7 +6,7 @@ import {
   getAllocationLogForDomainId,
   getVariantsForAllocation,
   getVolumeGroupData,
-  updateLetterVariantConfig,
+  updateLetterVariantPackSpecs,
   updateVolumeGroupData,
 } from "tests/helpers/allocation-helper";
 import { createPreparedV1Event } from "tests/helpers/event-fixtures";
@@ -63,7 +63,7 @@ test.describe("Allocator Rejected Allocation Tests", () => {
       });
 
       if (letterVariantMapping === 7) {
-        await updateLetterVariantConfig(letterVariant, [""]);
+        await updateLetterVariantPackSpecs(letterVariant, [""]);
       }
 
       const response = await sendSnsEvent(preparedEvent);
@@ -104,7 +104,9 @@ test.describe("Allocator Rejected Allocation Tests", () => {
           expect(lettersInDb.reasonText).toContain(
             `No pack specification found for id`,
           );
-          await updateLetterVariantConfig(letterVariant, ["notify-c5-colour"]); // update back to valid config for other tests
+          await updateLetterVariantPackSpecs(letterVariant, [
+            "notify-c5-colour",
+          ]); // update back to valid config for other tests
           break;
         }
         default: {
@@ -133,8 +135,9 @@ test.describe("Allocator Rejected Allocation Tests", () => {
       const letterVariant = getVariantsForAllocation(8);
       logger.info(`Testing volumeGroup with ${fieldToUpdate}: ${domainId}`);
 
-      const { originalEndDate, originalStartDate } =
-        await getVolumeGroupData(volumeGroupId);
+      const volumeGroupData = await getVolumeGroupData(volumeGroupId);
+      const originalStartDate = volumeGroupData.startDate;
+      const originalEndDate = volumeGroupData.endDate;
 
       const [futureStartDate] = new Date(Date.now() + 24 * 60 * 60 * 1000)
         .toISOString()

tests/helpers/allocation-helper.ts

@@ -405,10 +405,7 @@ export async function updateVolumeGroupData(
   );
 }
 
-export async function getVolumeGroupData(volumeGroupId: string): Promise<{
-  originalStartDate: string;
-  originalEndDate: string;
-}> {
+export async function getVolumeGroupData(volumeGroupId: string): Promise<any> {
   const { Item } = await docClient.send(
     new GetCommand({
       TableName: getSupplierConfigTableName(),
@@ -425,10 +422,7 @@ export async function getVolumeGroupData(volumeGroupId: string): Promise<{
     );
   }
 
-  return {
-    originalEndDate: Item.endDate,
-    originalStartDate: Item.startDate,
-  };
+  return Item;
 }
 
 export async function updateSupplierAllocation(
@@ -460,7 +454,7 @@ export async function updateSupplierAllocation(
   );
 }
 
-export async function updateLetterVariantConfig(
+export async function updateLetterVariantPackSpecs(
   letterVariantId: string,
   packSpecificationIds: string[],
 ) {