fix test and lint issue

Author: RossFaulds171

scripts/utilities/letter-test-data/src/__test__/helpers/create-letter-helpers.test.ts

@@ -33,6 +33,8 @@ describe("Create letter helpers", () => {
     const status = "PENDING" as LetterStatusType;
     const testLetter = "test-letter-standard";
 
+    (uploadFile as jest.Mock).mockResolvedValue({ hash: "abc123" });
+
     await createLetter({
       letterId,
       bucketName,
@@ -65,6 +67,7 @@ describe("Create letter helpers", () => {
       subject: "supplier-api/letter-test-data/letterId",
       billingRef: "specificationId",
       specificationBillingId: "billingId",
+      sha256Hash: "abc123",
     });
   });
 
@@ -116,6 +119,7 @@ describe("Create letter helpers", () => {
       source: "/data-plane/letter-rendering/letter-test-data",
       subject: "supplier-api/letter-test-data/letterId",
       specificationBillingId: "billingId",
+      sha256Hash: undefined,
     });
   });
 
@@ -131,7 +135,6 @@ describe("Create letter helpers", () => {
       groupId: "testGroupId",
       status: "PENDING" as LetterStatusType,
       url: "s3://bucket/testSupplierId/testLetter.pdf",
-      sha256Hash: "testHash",
     };
 
     const result = createLetterDto(params);
@@ -149,7 +152,6 @@ describe("Create letter helpers", () => {
       subject: "supplier-api/letter-test-data/testLetterId",
       billingRef: "testSpecId",
       specificationBillingId: "testBillingId",
-      sha256Hash: "testHash",
     });
   });
 });

scripts/utilities/letter-test-data/src/helpers/create-letter-helpers.ts

@@ -69,7 +69,6 @@ export function createLetterDto(params: {
   groupId: string;
   status: LetterStatusType;
   url: string;
-  sha256Hash?: string;
 }) {
   const {
     billingId,
@@ -79,7 +78,6 @@ export function createLetterDto(params: {
     status,
     supplierId,
     url,
-    sha256Hash,
   } = params;
 
   const letter: Omit<Letter, "ttl" | "supplierStatus" | "supplierStatusSk"> = {
@@ -95,7 +93,6 @@ export function createLetterDto(params: {
     subject: `supplier-api/letter-test-data/${letterId}`,
     billingRef: specificationId,
     specificationBillingId: billingId,
-    sha256Hash,
   };
 
   return letter;

scripts/utilities/letter-test-data/src/helpers/s3-helpers.ts

@@ -27,7 +27,7 @@ export default async function uploadFile(
 
     const command = new PutObjectCommand(uploadParams);
     const commandResult = await s3.send(command);
-    return {commandResult, hash};
+    return { commandResult, hash};
   } catch (error) {
     console.error("Error uploading file:", error);
     throw error;