Change response shape

Author: francisco-videira-nhs

infrastructure/terraform/components/api/resources/spec.tmpl.json

@@ -28,7 +28,7 @@
         "operationId": "getStatusId",
         "responses": {
           "200": {
-            "description": "Empty body"
+            "description": "OK"
           },
           "500": {
             "description": "Server error"

lambdas/api-handler/src/handlers/__tests__/get_status.test.ts

@@ -19,7 +19,7 @@ describe('API Lambda handler', () => {
 
     expect(result).toEqual({
       statusCode: 200,
-      body: '{}',
+      body: JSON.stringify({ code: 200 }, null, 2)
     });
   });
 
@@ -34,9 +34,10 @@ describe('API Lambda handler', () => {
     const getLetterDataHandler = createGetStatusHandler(mockedDeps);
     const result = await getLetterDataHandler(event,  mockDeep<Context>(), jest.fn());
 
-    expect(result).toEqual(expect.objectContaining({
-      statusCode: 500
-    }));
+    expect(result).toEqual({
+      statusCode: 500,
+      body: JSON.stringify({ code: 500 }, null, 2)
+    });
   });
 
 
@@ -51,9 +52,10 @@ describe('API Lambda handler', () => {
     const getLetterDataHandler = createGetStatusHandler(mockedDeps);
     const result = await getLetterDataHandler(event,  mockDeep<Context>(), jest.fn());
 
-    expect(result).toEqual(expect.objectContaining({
-      statusCode: 500
-    }));
+    expect(result).toEqual({
+      statusCode: 500,
+      body: JSON.stringify({ code: 500 }, null, 2)
+    });
   });
 
 

lambdas/api-handler/src/handlers/get-status.ts

@@ -17,10 +17,14 @@ export function createGetStatusHandler(deps: Deps): APIGatewayProxyHandler {
 
       return {
         statusCode: 200,
-        body: '{}'
+        body: JSON.stringify({ code: 200 }, null, 2)
       };
     } catch (error) {
-      return mapErrorToResponse(error, undefined, deps.logger);
+      deps.logger.error({ err: error }, 'Status endpoint error, services not available');
+      return {
+        statusCode: 500,
+        body: JSON.stringify({ code: 500 }, null, 2)
+      };
     }
   }
 }