CCM-11602: Update Get Letters endpoint#135
Merged
Merged
Conversation
* CCM-11580: OAS syntax fixes Remove 'requestedProductionStatus' from letter-related JSON schemas and update examples to singular form CCM-11580: Update serve-oas command CCM-11580: Update serve-oas command CCM-11580: Remove unneeded endpoints and resource types + Move getData endpoint under letter CCM-11580: Remove hello world endpoint CCM-11580: Remove hello world endpoint CCM-11580: Add sandbox handler metadata to endpoints CCM-11580: More fixes to examples syntax CCM-11580: Remove remaining reference to hello-world lambda CCM-11580: Remove remaining reference to hello-world lambda CCM-11580: add limit parameter to list letters endpoint CCM-11580: Update sandbox endpoints to match OAS CCM-11580: Update letter responses in Sandbox to match spec changes CCM-11580: implement get letter status endpoint in sandbox Add groupId to schema and examples * CCM-11580: remove x-eov extension from non sandox spec --------- Co-authored-by: mark.slowey1 <mark.slowey1@nhs.net>
Small change to fix Sonar cloud badges
simonlabarere
force-pushed
the
feature/CCM-11602_get_endpoint
branch
from
4b0d9f9 to
0828b17
Compare
masl2
previously approved these changes
Sep 15, 2025
m-houston
previously approved these changes
Sep 15, 2025
sidnhs
previously approved these changes
Sep 15, 2025
masl2
dismissed stale reviews from sidnhs, m-houston, and themself
via
8382a2a
francisco-videira-nhs
previously approved these changes
Sep 17, 2025
|
masl2
approved these changes
Sep 18, 2025
nhsd-david-wass
approved these changes
Sep 18, 2025
sidnhs
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the GET letters endpoint and create an example for Sandbox.
Note that the scope of the ticket has changed. We no longer want suppliers to be able to GET several pages of PENDING letters. We want them to get PENDING letters, acknowledge they have accepted them and then get a new page of PENDING letters.
Testing
Logging when Supplier ID not provided
Happy path (response + logging)
Empty response when no PENDING letters
Getting new letters after acknowledgement
Getting PENDING letters (note that the 'size' parameter is now called 'limit'):
Letters set to ACCEPTED:
Getting PENDING letters again returns new letters:
Context
Required for suppliers to get a list of letters to process.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.