Skip to content

CCM-12133: move interal-dev deploy to manual workflow#155

Merged
masl2 merged 9 commits into
mainfrom
feature/CCM-12133_move-proxy-deploy-from-build
Sep 12, 2025
Merged

CCM-12133: move interal-dev deploy to manual workflow#155
masl2 merged 9 commits into
mainfrom
feature/CCM-12133_move-proxy-deploy-from-build

Conversation

@masl2

@masl2 masl2 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@masl2 masl2 marked this pull request as ready for review September 12, 2025 08:32
@masl2 masl2 requested review from a team as code owners September 12, 2025 08:32
sidnhs
sidnhs previously approved these changes Sep 12, 2025

@francisco-videira-nhs francisco-videira-nhs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few comments

Comment thread .github/workflows/manual-proxy-internal-dev-deploy.yaml Outdated
Comment thread .github/workflows/manual-proxy-internal-dev-deploy.yaml Outdated

@francisco-videira-nhs francisco-videira-nhs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@masl2 masl2 requested a review from sidnhs September 12, 2025 15:02
@masl2 masl2 enabled auto-merge (squash) September 12, 2025 15:14
@masl2 masl2 disabled auto-merge September 12, 2025 15:15
@masl2 masl2 enabled auto-merge (squash) September 12, 2025 15:15
@sonarqubecloud

Copy link
Copy Markdown

@masl2 masl2 merged commit 3b7b924 into main Sep 12, 2025
31 checks passed
@masl2 masl2 deleted the feature/CCM-12133_move-proxy-deploy-from-build branch September 12, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants