Authoriser lambda#230
Merged
Merged
Conversation
added gitleaks ignore
masl2
previously requested changes
Nov 11, 2025
masl2
left a comment
masl2
left a comment
Contributor
There was a problem hiding this comment.
Needs minor target corrections - and the name of the header being used should be NHSD-Supplier-ID
Also add an alarm to the infrastructure keying on the generate cert expiry metric for visibility
10 tasks
nhsd-david-wass
previously approved these changes
Nov 14, 2025
francisco-videira-nhs
previously approved these changes
Nov 14, 2025
sidnhs
previously approved these changes
Nov 17, 2025
masl2
dismissed stale reviews from sidnhs, nhsd-david-wass, and francisco-videira-nhs
via
1aff0f9
stevebux
commented
Nov 17, 2025
stevebux
commented
Nov 17, 2025
stevebux
commented
Nov 17, 2025
stevebux
left a comment
stevebux
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM. (I would approve, but I can't because I created the PR)
masl2
previously approved these changes
Nov 18, 2025
francisco-videira-nhs
approved these changes
Nov 18, 2025
masl2
approved these changes
Nov 19, 2025
masl2
added a commit
that referenced
this pull request
Jan 5, 2026
* add product id header * CCM-11600: supplier repository and table * CCM-11600: cli interface for supplier repo * CCM-11600: lock for new packages * Update .gitleaksignore added gitleaks ignore * CCM-11600: fix some imports * Add certificate expiry check * Added supplier ID lookup * Test fix * Further development * Fix dependencies * Temp commit to force cloudwatch logging * Removed Cloudwatch client * Tidy up packages * CCM-11600: correct target attr * CCM-11600: header name, targets, add alarm * CCM-11600: correct env ref * CCM-11600: fix header lookup * lockfile * remove placeholder blurb * fix copy pasta * workspace refs * lock * CCM-11600: header references, format, name consistency --------- Co-authored-by: David Wass <david.wass2@nhs.net> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Co-authored-by: Mark Slowey <mark.slowey1@nhs.net> Co-authored-by: Tim Ireland <tim.ireland@hscic.gov.uk> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.