Skip to content

CCM-13615: Status Update Transformer Source#309

Merged
masl2 merged 20 commits into
mainfrom
feature/CCM-13615_letter-status-source
Jan 16, 2026
Merged

CCM-13615: Status Update Transformer Source#309
masl2 merged 20 commits into
mainfrom
feature/CCM-13615_letter-status-source

Conversation

@masl2

@masl2 masl2 commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Description

Add account (short name) and environment to the status update source field to enable better routing and filtering for the events

Additionally allow INSERT events as these will be linked to new letter creation and will inform other services a letter has been registered/allocated in the supplier api (via PENDING status)

Finally move payload extraction to discrete non pipe step to help ensure payloads are logged - filtered payloads were not being logged

Enables identification of account and environment source for events
Ensures PENDING statuses will be generated
Improves logging for debugging

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@masl2 masl2 requested review from a team as code owners December 16, 2025 14:04
@masl2 masl2 force-pushed the feature/CCM-13615_letter-status-source branch from 1adb1f1 to 588bf5a Compare December 16, 2025 15:35
@masl2 masl2 force-pushed the feature/CCM-13615_letter-status-source branch from 588bf5a to 6d35b7f Compare December 17, 2025 12:21
Comment thread lambdas/letter-updates-transformer/src/letter-updates-transformer.ts Outdated
m-houston
m-houston previously approved these changes Dec 17, 2025
…mer.ts

Co-authored-by: Mike Houston <60653100+m-houston@users.noreply.github.com>

@stevebux stevebux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of very minor comments

Comment thread lambdas/letter-updates-transformer/src/letter-updates-transformer.ts Outdated
stevebux
stevebux previously approved these changes Dec 18, 2025

@stevebux stevebux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-houston
m-houston previously approved these changes Dec 23, 2025
@masl2

masl2 commented Dec 24, 2025

Copy link
Copy Markdown
Contributor Author

Should probably wait until after #280 to ensure we don't lose the value passthrough to the outbound events

Edit: the above is now merged, this pr can proceed

sidnhs
sidnhs previously approved these changes Jan 16, 2026
Comment thread lambdas/letter-updates-transformer/src/mappers/__tests__/letter-mapper.test.ts Outdated
@masl2 masl2 enabled auto-merge (squash) January 16, 2026 16:57
@masl2 masl2 merged commit dc897c5 into main Jan 16, 2026
36 of 37 checks passed
@masl2 masl2 deleted the feature/CCM-13615_letter-status-source branch January 16, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants