Skip to content

remove eventbridge wrapper if present#350

Merged
masl2 merged 5 commits into
mainfrom
fix/eventbridge-wrapper
Jan 16, 2026
Merged

remove eventbridge wrapper if present#350
masl2 merged 5 commits into
mainfrom
fix/eventbridge-wrapper

Conversation

@masl2

@masl2 masl2 commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Description

Fix parsing bug: https://nhsd-jira.digital.nhs.uk/browse/CCM-13965

Messages sourced from the Account bus will have an additional eventbridge wrapper around the cloud event

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@masl2 masl2 requested a review from a team as a code owner January 16, 2026 14:39

@francisco-videira-nhs francisco-videira-nhs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I wonder if it will impact Vlasis' test tests/performance/testCases/send-prepared-letter-request.spec.ts : https://github.com/NHSDigital/nhs-notify-supplier-api/pull/328/changes#diff-edc3fe4a0b3883af62846c734596d6b63b2ad6bf64292df615be1b74c5d9ce7cR36

Comment thread lambdas/upsert-letter/src/handler/__tests__/upsert-handler.test.ts Outdated
Comment thread lambdas/upsert-letter/src/handler/upsert-handler.ts
@masl2 masl2 merged commit b585191 into main Jan 16, 2026
38 checks passed
@masl2 masl2 deleted the fix/eventbridge-wrapper branch January 16, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants