Skip to content

CCM-12860: Create Alarms for Metrics Exceeding Thresholds#370

Merged
francisco-videira-nhs merged 32 commits into
mainfrom
feature/CCM-12860
Feb 27, 2026
Merged

CCM-12860: Create Alarms for Metrics Exceeding Thresholds#370
francisco-videira-nhs merged 32 commits into
mainfrom
feature/CCM-12860

Conversation

@francisco-videira-nhs

@francisco-videira-nhs francisco-videira-nhs commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Description

Minimatch vulnerability:
https://github.com/NHSDigital/nhs-notify-supplier-api/actions/runs/22230122480/job/64307183256

Added skip-trivy-package label to skip Trivy scan.

This https://nhsd-jira.digital.nhs.uk/browse/CCM-14741 is the ticket to resolve the vuln in this repo.

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Comment thread infrastructure/terraform/components/api/alarms.tf Outdated
sidnhs
sidnhs previously approved these changes Feb 23, 2026
@aidenvaines-cgi aidenvaines-cgi changed the title Feature/ccm 12860 Feature/CCM-12860 Feb 23, 2026
@francisco-videira-nhs francisco-videira-nhs changed the title Feature/CCM-12860 CCM-12860: Create Alarms for Metrics Exceeding Thresholds Feb 23, 2026
@aidenvaines-cgi

Copy link
Copy Markdown
Contributor

CCM-14686 does not apply to this repository and is not curently suitable for the skip-trivy label

@stevebux stevebux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of comments

Comment thread tests/component-tests/apiGateway-tests/update-letter-status.spec.ts Outdated
Comment thread tests/helpers/generate-fetch-test-data.ts Outdated
@francisco-videira-nhs francisco-videira-nhs merged commit e75446d into main Feb 27, 2026
38 checks passed
@francisco-videira-nhs francisco-videira-nhs deleted the feature/CCM-12860 branch February 27, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants