Skip to content

CCM-13359 - Determine Volume Group Eligibility#422

Merged
nhsd-david-wass merged 22 commits into
mainfrom
feature/CCM-13359-Volume-Group-Eligibility
Mar 25, 2026
Merged

CCM-13359 - Determine Volume Group Eligibility#422
nhsd-david-wass merged 22 commits into
mainfrom
feature/CCM-13359-Volume-Group-Eligibility

Conversation

@nhsd-david-wass

Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-david-wass nhsd-david-wass requested a review from a team as a code owner February 19, 2026 15:20
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-13359-Volume-Group-Eligibility branch 5 times, most recently from eed6694 to fa5d2e1 Compare February 20, 2026 10:08
@nhsd-david-wass nhsd-david-wass requested a review from a team as a code owner February 20, 2026 15:41
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-13359-Volume-Group-Eligibility branch 11 times, most recently from fe90b52 to 7ec7e85 Compare February 26, 2026 15:41

@stevebux stevebux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just a few comments

Comment thread internal/datastore/src/supplier-config-repository.ts
Comment thread internal/datastore/src/__test__/supplier-config-repository.test.ts Outdated
Comment thread lambdas/supplier-allocator/src/services/supplier-config.ts Outdated
Comment thread lambdas/supplier-allocator/src/services/supplier-config.ts
Comment thread lambdas/supplier-allocator/src/services/supplier-config.ts
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-13359-Volume-Group-Eligibility branch 6 times, most recently from 07325d8 to e1ab7cd Compare March 16, 2026 13:32
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-13359-Volume-Group-Eligibility branch 3 times, most recently from 87fd5fb to bf8d500 Compare March 17, 2026 15:00
@nhsd-david-wass nhsd-david-wass force-pushed the feature/CCM-13359-Volume-Group-Eligibility branch from ca1f6bf to 81ba144 Compare March 25, 2026 11:35
@nhsd-david-wass nhsd-david-wass changed the title Supplier Config table CCM-13359 - Determine Volume Group Eligibility Mar 25, 2026
stevebux
stevebux previously approved these changes Mar 25, 2026
Comment thread infrastructure/terraform/components/api/locals.tf Outdated
@nhsd-david-wass nhsd-david-wass merged commit 65d727a into main Mar 25, 2026
37 checks passed
@nhsd-david-wass nhsd-david-wass deleted the feature/CCM-13359-Volume-Group-Eligibility branch March 25, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants